Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase PRs checked during release to 100 #204

Merged
merged 2 commits into from
Jul 25, 2019
Merged

fix: increase PRs checked during release to 100 #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c692950
fix: checking last 25 commits not sufficient
bcoe Jul 25, 2019
88339c9
lint: fix linting
bcoe Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ export class GitHub {

async findMergedReleasePR(
labels: string[],
perPage = 25
perPage = 100
): Promise<GitHubReleasePR | undefined> {
const pullsResponse = (await this.request(
`GET /repos/:owner/:repo/pulls?state=closed&per_page=${perPage}${
Expand Down Expand Up @@ -475,9 +475,7 @@ export class GitHub {
// pull-request body.
if (openReleasePR && openReleasePR.body === options.body) {
checkpoint(
`PR https://github.com/${this.owner}/${this.repo}/pull/${
openReleasePR.number
} remained the same`,
`PR https://github.com/${this.owner}/${this.repo}/pull/${openReleasePR.number} remained the same`,
CheckpointType.Failure
);
return -1;
Expand Down
2 changes: 1 addition & 1 deletion test/release-pr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe('GitHub', () => {
const req = nock('https://api.github.com')
// check to see if this PR was already landed and we're
// just waiting on the autorelease.
.get('/repos/googleapis/release-please/pulls?state=closed&per_page=25')
.get('/repos/googleapis/release-please/pulls?state=closed&per_page=100')
.reply(200, undefined)
// fetch semver tags, this will be used to determine
// the delta since the last release.
Expand Down