-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address a couple more bugs with Ruby libraries #242
Conversation
we might actually want to fix grafeas client's naming in the ruby mono repo. |
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=======================================
Coverage 77.76% 77.76%
=======================================
Files 21 21
Lines 2590 2590
Branches 194 194
=======================================
Hits 2014 2014
Misses 564 564
Partials 12 12
Continue to review full report at Codecov.
|
@@ -123,7 +123,7 @@ export class ReleasePR { | |||
if (pr.number !== currentPRNumber) { | |||
// on mono repos that maintain multiple open release PRs, we use the | |||
// pull request title to differentiate between PRs: | |||
if (includePackageName && !pr.title.includes(this.packageName)) { | |||
if (includePackageName && !pr.title.includes(` ${this.packageName} `)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, why do we need the spaces?
lib/grafeas
notlib/grafeas-client
, we should be mindful of any other libraries that are edge cases.