Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add strategy for non-mono-repo Ruby releases #300

Merged
merged 2 commits into from
Oct 28, 2019
Merged

feat: add strategy for non-mono-repo Ruby releases #300

merged 2 commits into from
Oct 28, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 25, 2019

I have not tested this yet, but I think it should work for Ruby applications, it introduces additional config option versionFile, which we are going to use to point to version.rb (which has a location that can be difficult to infer in a project).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2019
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #300 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #300      +/-   ##
=========================================
+ Coverage    81.9%   81.9%   +<.01%     
=========================================
  Files          24      24              
  Lines        2978    2979       +1     
  Branches      250     250              
=========================================
+ Hits         2439    2440       +1     
  Misses        529     529              
  Partials       10      10
Impacted Files Coverage Δ
src/release-pr.ts 85.59% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf7ef1...caddf67. Read the comment docs.

Copy link

@TheRoyalTnetennba TheRoyalTnetennba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this

@bcoe bcoe changed the title [WIP] feat: add strategy for non-mono-repo Ruby releases feat: add strategy for non-mono-repo Ruby releases Oct 28, 2019
@bcoe bcoe merged commit 8e71380 into master Oct 28, 2019
@bcoe bcoe deleted the ruby branch October 28, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants