-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect default branch #468
Conversation
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 79.74% 79.79% +0.05%
==========================================
Files 40 40
Lines 4640 4657 +17
Branches 374 377 +3
==========================================
+ Hits 3700 3716 +16
- Misses 939 940 +1
Partials 1 1
Continue to review full report at Codecov.
|
src/graphql-to-commits.ts
Outdated
@@ -124,7 +122,7 @@ async function graphqlToCommit( | |||
let prEdge: PREdge = commitEdge.node.associatedPullRequests.edges[0]; | |||
|
|||
// if the commit.sha and mergeCommit.oid do not match, assume that this | |||
// was a push to master and drop the commit. | |||
// was a push directl to the default branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in the comment
3eddaa4
to
c6306a4
Compare
Now programmatically detects default branch, making it easier to use an alternative.
This also should make it easier to support multiple release branches.
@feywind I expect this overlaps a bit with your work, but might make it a bit easier to see that work over the finish line 馃憣