-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TF versions updater #629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 80.73% 81.99% +1.26%
==========================================
Files 45 46 +1
Lines 5418 5477 +59
Branches 410 441 +31
==========================================
+ Hits 4374 4491 +117
+ Misses 1043 985 -58
Partials 1 1
Continue to review full report at Codecov.
|
|
||
const fixturesPath = './test/updaters/fixtures'; | ||
|
||
describe('versions.tf', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharathkkb Can we add a test fixture for a submodule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morgante sg, currently logic for submodule is in the releaser so we may need to add a test there.
// A module may have submodules, so find all versions.tf to update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharathkkb when adding tests for releasers, take a look at these tests:
https://github.com/googleapis/release-please/blob/master/test/releasers/simple.ts#L43
I've been switching to using sinon and mocking for tests, rather than nock (_which requires you enumerate every HTTP endpoint you hit with the GitHub API). I think you'll find sinon easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #628
/cc @morgante