New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to specify extra files for releasers to consider #850
Conversation
Currently, only Java utilizies this option, but this could be used by any release strategy.
cc @igorbernstein2 This would be a more generalized solution for being able to make replacements in one-off files (without hard-coding a list) |
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
+ Coverage 93.77% 93.78% +0.01%
==========================================
Files 64 64
Lines 9203 9218 +15
Branches 936 992 +56
==========================================
+ Hits 8630 8645 +15
Misses 570 570
Partials 3 3
Continue to review full report at Codecov.
|
@@ -299,6 +299,18 @@ export class JavaYoshi extends ReleasePR { | |||
}) | |||
); | |||
}); | |||
|
|||
this.extraFiles.forEach(path => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my slight concern here is behavior that's one-language specific, perhaps add a TODO to flesh out this behavior. I'm imagining you'd eventually pass a file plus the updater to apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that will be too much config. The general use case for extra files would be one-offs that update the version strings in a file. Each language will want a generic way to do this - we don't want a bunch of one-off updaters for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with the note that I'd like to minimize language specific features if we can make them more generic.
🤖 I have created a release \*beep\* \*boop\* --- ## [11.7.0](https://www.github.com/googleapis/release-please/compare/v11.6.0...v11.7.0) (2021-04-09) ### Features * add ability to specify extra files for releasers to consider ([#850](https://www.github.com/googleapis/release-please/issues/850)) ([f7079fd](https://www.github.com/googleapis/release-please/commit/f7079fd7bb07104e9ed249d870f7ae59b1cdf15a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Currently, only Java utilizes this option, but this could be used by
any release strategy.
Towards #305
Towards #597