Add java release commands #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love this. Gonna try to review today after I solve some bugs here. |
theacodes
reviewed
Aug 23, 2018
releasetool/commands/start/java.py
Outdated
|
|
||
| def gather_changes(ctx: Context) -> None: | ||
| click.secho(f"> Gathering changes since {ctx.last_release_version}", fg="cyan") | ||
| ctx.changes = releasetool.git.summary_log(ctx.last_release_committish) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
releasetool/commands/start/java.py
Outdated
|
|
||
| def gather_pom_xml_files(ctx: Context) -> None: | ||
| ctx.pom_files = glob('**/pom.xml', recursive=True) | ||
| print(ctx.pom_files) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
releasetool/commands/start/java.py
Outdated
|
|
||
| def update_pom_xml(ctx: Context) -> None: | ||
| click.secho("> Updating snapshot versions in pom.xml files.", fg="cyan") | ||
| print(ctx.snapshot_version) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
releasetool/commands/tag/java.py
Outdated
| if match is not None: | ||
| ctx.release_tag = match.group(1) | ||
| else: | ||
| print( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
chingor13
force-pushed
the
java-release
branch
from
b1fa276
to
c88c41d
Compare
theacodes
approved these changes
Aug 23, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general process for java is:
Java libraries do not maintain a running CHANGELOG.md (can revisit this later) so we put the release notes in the PR body and extract them for the GitHub release.
Example PR: googleapis/google-auth-library-java#179