feat!: require node 18 (#5225)

googleapis · Sep 18, 2023 · b2f851a · b2f851a
1 parent 2f1d9bd
commit b2f851a
Show file tree

Hide file tree

Showing 13 changed files with 1,207 additions and 588 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -34,7 +34,7 @@ jobs:
       - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3
       - uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
         with:
-          node-version: ${{ (matrix.package == 'gcf-utils' || matrix.package == 'issue-utils' || matrix.package == 'canary-bot' || matrix.package == 'datastore-lock' ) && 18 || 14 }}
+          node-version: ${{ (endsWith(matrix.package, '-utils') || matrix.package == 'canary-bot' || matrix.package == 'datastore-lock' || matrix.package == 'object-selector' ) && 18 || 14 }}
       - run: echo ./packages/${{ matrix.package }}
       - run: cd ./packages/${{ matrix.package }}
       - run: npm ci

diff --git a/packages/bot-config-utils/package-lock.json b/packages/bot-config-utils/package-lock.json
diff --git a/packages/bot-config-utils/package.json b/packages/bot-config-utils/package.json
@@ -6,7 +6,7 @@
     "compile": "tsc -p .",
     "pretest": "npm run compile",
     "prepare": "npm run compile",
-    "test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha ./build/test",
+    "test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha --node-option no-experimental-fetch ./build/test",
     "test:snap": "SNAPSHOT_UPDATE=1 npm test",
     "system-test": "npm run pretest && cross-env LOG_LEVEL=fatal mocha ./build/test/integration",
     "fix": "gts fix",
@@ -19,7 +19,7 @@
   "dependencies": {
     "ajv": "^8.11.0",
     "ajv-formats": "^2.1.1",
-    "gcf-utils": "^14.0.1",
+    "gcf-utils": "^15.0.0",
     "js-yaml": "^4.1.0",
     "jsonwebtoken": "^9.0.0"
   },
@@ -40,7 +40,7 @@
     "typescript": "^4.9.4"
   },
   "engines": {
-    "node": ">= 14"
+    "node": ">= 18"
   },
   "keywords": [
     "Bot config",

diff --git a/packages/cron-utils/package-lock.json b/packages/cron-utils/package-lock.json
diff --git a/packages/cron-utils/package.json b/packages/cron-utils/package.json
@@ -6,7 +6,7 @@
     "compile": "tsc -p .",
     "pretest": "npm run compile",
     "prepare": "npm run compile",
-    "test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha ./build/test",
+    "test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha --node-option no-experimental-fetch ./build/test",
     "system-test": "npm run pretest && cross-env LOG_LEVEL=fatal mocha ./build/test/integration",
     "fix": "gts fix",
     "lint": "gts check"
@@ -41,7 +41,7 @@
     "typescript": "^4.9.4"
   },
   "engines": {
-    "node": ">= 14"
+    "node": ">= 18"
   },
   "keywords": [],
   "author": "Jeff Ching <chingor@google.com>",

diff --git a/packages/git-file-utils/package-lock.json b/packages/git-file-utils/package-lock.json
diff --git a/packages/git-file-utils/package.json b/packages/git-file-utils/package.json
@@ -6,7 +6,7 @@
     "compile": "tsc -p .",
     "pretest": "npm run compile",
     "prepare": "npm run compile",
-    "test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha ./build/test",
+    "test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha --node-option no-experimental-fetch ./build/test",
     "test:snap": "SNAPSHOT_UPDATE=1 npm test",
     "system-test": "npm run pretest && cross-env LOG_LEVEL=fatal mocha ./build/test/integration",
     "fix": "gts fix",
@@ -39,7 +39,7 @@
     "typescript": "^4.9.4"
   },
   "engines": {
-    "node": ">= 14"
+    "node": ">= 18"
   },
   "keywords": [
     "Git data API"

diff --git a/packages/label-utils/.eslintrc.json b/packages/label-utils/.eslintrc.json
@@ -1,3 +1,4 @@
 {
-  "extends": "./node_modules/gts"
+  "extends": "./node_modules/gts",
+  "root": true
 }