Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code contributors outside Google can't run owl bot post processor images #1790

Closed
SurferJeffAtGoogle opened this issue May 18, 2021 · 6 comments
Closed

Code contributors outside Google can't run owl bot post processor images #1790

SurferJeffAtGoogle opened this issue May 18, 2021 · 6 comments
Assignees
@SurferJeffAtGoogle
Labels
bot: owl-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@SurferJeffAtGoogle
Copy link
Contributor

because the post processor images live in the private github project github-automation-bots.

We should move the post processor images to the cloud-devrel-public-resources project, and update the .OwlBot.yaml config files accordingly.
@SurferJeffAtGoogle SurferJeffAtGoogle added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. bot: owl-bot priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 18, 2021
@SurferJeffAtGoogle
Copy link
Contributor Author

Example: googleapis/python-pubsub#411 (comment)

@parthea parthea mentioned this issue May 19, 2021
Merged
@parthea parthea added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 8, 2021
@sofisl sofisl added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 8, 2021
@chingor13 chingor13 added type: process A process-related concern. May include testing, release, or the like. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 8, 2021
@parthea parthea assigned parthea and unassigned SurferJeffAtGoogle Jun 8, 2021
@parthea parthea mentioned this issue Jun 15, 2021
Closed
@parthea
Copy link
Contributor

parthea commented Aug 5, 2021 •
edited

I've set up a build trigger to push new owlbot post processor images to cloud-devrel-public-resources. I've updated the .github/.OwlBot.lock.yaml file in python-pubsub to use the public post processor image gcr.io/cloud-devrel-public-resources/owlbot-python:latest here however owl bot is not opening PRs when a new post processor image is pushed. I believe that owlbot needs to be updated to scan cloud-devrel-public-resources in addition to repo-automation-bots for new images pushed to the container registry possibly related to this section of the code.

@parthea parthea added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: process A process-related concern. May include testing, release, or the like. labels Sep 2, 2021
@parthea
Copy link
Contributor

parthea commented Sep 2, 2021

Bumping to P1 as this is impacting the workflow for external maintainers.

@parthea parthea removed their assignment Sep 2, 2021
@parthea parthea mentioned this issue Sep 2, 2021
Merged
gcf-merge-on-green bot pushed a commit to googleapis/python-pubsub that referenced this issue Sep 2, 2021
@parthea
chore: remove obsolete replacements in owlbot.py (#492)
8ae2b5a 
This PR also switches the post processor image from `gcr.io/cloud-devrel-public-resources/owlbot-python:latest` to `gcr.io/repo-automation-bots/owlbot-python:latest` as there is a bug in owlbot where it only opens PRs when the post processor image is in the project `repo-automation-bots`. I've bumped the priority of the bug to p1 here: googleapis/repo-automation-bots#1790
@SurferJeffAtGoogle SurferJeffAtGoogle self-assigned this Sep 2, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle mentioned this issue Sep 2, 2021
Merged
This was referenced Sep 2, 2021
Merged
Closed
SurferJeffAtGoogle added a commit to SurferJeffAtGoogle/synthtool that referenced this issue Sep 2, 2021
@SurferJeffAtGoogle
feat: publish post-processor images to cloud-devrel-public-resources
81c9cc4 
One step in resolving googleapis/repo-automation-bots#1790.
@SurferJeffAtGoogle SurferJeffAtGoogle mentioned this issue Sep 2, 2021
Merged
@parthea parthea added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 3, 2021
@parthea
Copy link
Contributor

parthea commented Sep 3, 2021

bumping back to p2 as we are now unblocked (functionality is working)

SurferJeffAtGoogle added a commit to googleapis/synthtool that referenced this issue Sep 8, 2021
@SurferJeffAtGoogle
feat: publish post-processor images to cloud-devrel-public-resources (#…
3871c1e 
…1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
gcf-owl-bot bot added a commit to googleapis/cloud-profiler-nodejs that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
9a2f168 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:7ae953d2adaad62a30933b3797b11245b9dcc942e465614280cd566a599c7a3e
gcf-owl-bot bot added a commit to googleapis/cloud-trace-nodejs that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources (#…
87ca1a1 
…1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:7ae953d2adaad62a30933b3797b11245b9dcc942e465614280cd566a599c7a3e
gcf-owl-bot bot added a commit to googleapis/java-apigee-connect that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
22e2881 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-artifact-registry that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
44fdce8 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-billing that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
29231cb 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/nodejs-bigquery that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources (#…
0f14e71 
…1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:7ae953d2adaad62a30933b3797b11245b9dcc942e465614280cd566a599c7a3e
gcf-owl-bot bot added a commit to googleapis/java-gsuite-addons that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
9043dfc 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-os-login that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
ba3c6f8 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-datacatalog that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
fc57ee6 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-recommender that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
552ffa2 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-shell that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
8100caf 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-redis that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
39de759 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-tpu that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
a224ee2 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-webrisk that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
e74c297 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-texttospeech that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
ca95ed9 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-service-usage that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
9006bc6 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-dialogflow that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
169d7a8 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-websecurityscanner that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
cda2362 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-monitoring-dashboards that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
39942ed 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/java-translate that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
3548834 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:74e6e91f946530fa28ca045bc33f37490122c1ca57630372d2d6ec9ff3758ebe
gcf-owl-bot bot added a commit to googleapis/nodejs-video-intelligence that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources …
4e56425 
…(#1203)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:7ae953d2adaad62a30933b3797b11245b9dcc942e465614280cd566a599c7a3e
SurferJeffAtGoogle pushed a commit to googleapis/nodejs-bigquery that referenced this issue Sep 8, 2021
@gcf-owl-bot
feat: publish post-processor images to cloud-devrel-public-resources (#…
e852cb2 
…1203) (#1005)

* feat: publish post-processor images to cloud-devrel-public-resources

One step in resolving googleapis/repo-automation-bots#1790.

* kick cla/google
Source-Link: googleapis/synthtool@3871c1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:7ae953d2adaad62a30933b3797b11245b9dcc942e465614280cd566a599c7a3e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@SurferJeffAtGoogle
Copy link
Contributor Author

I updated all our repos with an .OwlBot.yaml to point to cloud-devrel-public-resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels
bot: owl-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chingor13 @parthea @SurferJeffAtGoogle @sofisl