Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-please closed a PR it did not open #277

Closed
busunkim96 opened this issue Feb 11, 2020 · 1 comment
Closed

release-please closed a PR it did not open #277

busunkim96 opened this issue Feb 11, 2020 · 1 comment
Assignees
@bcoe
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented Feb 11, 2020 •
edited
Loading

release-please bot closed a PR that it did not open. The PR updated a dependency in the setup.py.

See googleapis/python-storage#45

image
@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 11, 2020
@chingor13
Copy link
Contributor

Maybe fixed by: googleapis/release-please#358

@bcoe bcoe mentioned this issue Feb 14, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 14, 2020
@bcoe
fix: new release-please with fix for Python
755aeaa 
updates release-please, addressing #277.

also removes `probot` dependency, which we get implicitly through `gcf-utils` (there were annoying TypeScript build issues due to these versions sometimes getting out of whack).
yoshi-automation added a commit that referenced this issue Apr 1, 2020
@yoshi-automation
fix: new release-please with fix for Python
919ad06 
755aeaa
commit 755aeaa
Author: Benjamin E. Coe <bencoe@google.com>
Date:   Fri Feb 14 14:21:19 2020 -0800

    fix: new release-please with fix for Python

    updates release-please, addressing #277.

    also removes `probot` dependency, which we get implicitly through `gcf-utils` (there were annoying TypeScript build issues due to these versions sometimes getting out of whack).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcoe bcoe

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @bcoe @busunkim96