fix(blunderbuss): handle assign_issues_by only config #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tbpg
approved these changes
Nov 16, 2020
| - labels: | ||
| - 'api: logging' | ||
| to: | ||
| - tormund |
There was a problem hiding this comment.
This is a real user, so it might be good to use another username. 🐶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1123 - dug through the logs, and it was pointing towards a run where this issue was opened:
googleapis/google-cloud-dotnet#5576
The repo uses the config here:
https://github.com/googleapis/google-cloud-dotnet/blob/master/.github/blunderbuss.yml
There was a bit of code where I think
undefinedwas getting passed around, because we thought we were smarter than the TypeScript compiler (we weren't)