Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hanging cron pr #1261

Merged
merged 4 commits into from
Jan 6, 2021
Merged

fix: hanging cron pr #1261

merged 4 commits into from
Jan 6, 2021

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Dec 23, 2020

No description provided.

@sofisl sofisl requested a review from a team December 23, 2020 19:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2020
@sofisl sofisl requested a review from bcoe December 23, 2020 20:05
bcoe
bcoe reviewed Dec 24, 2020
View reviewed changes
packages/merge-on-green/src/merge-on-green.ts Outdated
@@ -518,16 +518,9 @@ function handler(app: Application) {

//because we're searching for the PRs, and not getting the installation ID, we have to use
//the bot's installation ID to call the API. So, we need to make sure it matches the repo owner
if (context.payload.cron_org) {
if (context.payload.pickUp === true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the pickUp variable set in the cron? I love this design of using the search API, but don't love the variable name pickUp.

When would pickUp not be set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made up a random variable name that we could add to the body. I just changed it to find_hanging_prs, and I was thinking of only setting it as true in that cron job!

@sofisl sofisl requested a review from bcoe December 28, 2020 20:01
@sofisl sofisl merged commit 985b284 into googleapis:master Jan 6, 2021
sofisl added a commit that referenced this pull request Jan 6, 2021
@sofisl
Revert "fix(merge-on-green): hanging cron pr (#1261)"
13670c9 
This reverts commit 985b284.
sofisl added a commit that referenced this pull request Jan 6, 2021
@sofisl
fix(merge-on-green): revert adding cron job (#1264)
473b7e6 
* Revert "fix(merge-on-green): hanging cron pr (#1261)"

This reverts commit 985b284.

* Revert "fix: add cron job to pick up hanging prs (#1217)"

This reverts commit 628e32c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sofisl @bcoe