Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trusted): add optional comment configuration #1682

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Apr 26, 2021

Fixes #1678. This introduces a config option so that repositories which use Cloud Build can opt into a comment instead of a label. The config would look like this:

annotations:
  - type: comment
    text: "/gcbrun"

Also some vanity test additions to get coverage to 100%.

@JustinBeckwith JustinBeckwith requested a review from a team April 26, 2021 06:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2021
@JustinBeckwith JustinBeckwith merged commit a12f302 into master Apr 26, 2021
@JustinBeckwith JustinBeckwith deleted the runny branch April 26, 2021 21:32
suztomo added a commit to googleapis/java-bigtable that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[trusted-contributions-gcf]: consider adding a /gcbrun comment
2 participants