feat: add bot for npm publication through wombat #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
changed the title
bcoe
force-pushed
the
publish-bot
branch
2 times, most recently
from
5952336
to
18a8531
Compare
JustinBeckwith
approved these changes
Dec 27, 2019
packages/publish/src/app.ts
Outdated
| @@ -0,0 +1,21 @@ | |||
| /** | |||
There was a problem hiding this comment.
Can we use new license headers please?
| dest.on('error', reject); | ||
| dest.on('close', () => { | ||
| app.log.info('finished unpacking tarball'); | ||
| return resolve(); |
There was a problem hiding this comment.
Being pedantic, but can you split up the return and resolve?
packages/publish/test/publish.ts
Outdated
| @@ -0,0 +1,142 @@ | |||
| /** | |||
There was a problem hiding this comment.
Did you mean to check in the tarball above?
tbpg
reviewed
Dec 27, 2019
|
|
||
| // Skip publication unless it's explicitly enabled. | ||
| if (!remoteConfiguration) { | ||
| app.log.info(`publish not configured for (${repoName})`); |
There was a problem hiding this comment.
Consider using the repo name as a prefix for all logs.
There was a problem hiding this comment.
👍 rather than doing so in this PR, perhaps we could create a tracking issue to override the default logger for all our bots; it would be nice to add a bit more context in the logs in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot for publishing to npm from cloud function, using wombat dressing room.