Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding DEE Asset labels #5032

Closed
wants to merge 3 commits into from

Conversation

rsamborski
Copy link
Member

Adding DEE asset labels to support auto-tagging efforts. See go/dee-auto-tagging for more information.

Adding DEE asset labels to support auto-tagging efforts. See go/dee-auto-tagging for more information.
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will add labels to every repository that this bot is installed on. These do not feel like they belong on every repository.

If this is for use with auto-label, we could add a feature to that bot that adds necessary labels if they exist in the auto-label config.

@rsamborski
Copy link
Member Author

This will add labels to every repository that this bot is installed on. These do not feel like they belong on every repository.

If this is for use with auto-label, we could add a feature to that bot that adds necessary labels if they exist in the auto-label config.

To clarify we are going to use these labels without auto-label too. There might be situations in which the label is added manually by a DEE member and then processed by internal tagging tool running on Buganizer mirrored issues (see go/dee-ops-live-docs and dee.yaml).

I could manually add these labels to DEE owned repositories, but if you look into the dee.yaml config file you will notice that we already monitor quite a few of them. Manually making sure they all have proper labels is a quite cumbersome task, so I naturally leaned towards the use of this bot.

@chingor13
Copy link
Contributor

If you want to manage these centrally, I would suggest adding a configuration option (like includeAssetLabels) for opting in to this class of labels in a configuration file (like .github/label-sync.yaml). This would require adding configuration to each of the repositories you own, but I don't think these are desired in 200+ other repositories that this bot is installed on.

@rsamborski
Copy link
Member Author

Thanks for the suggestion. I have reported a feature request under #5040. Closing this PR for now.

@rsamborski rsamborski closed this Apr 25, 2023
@SurferJeffAtGoogle
Copy link
Contributor

This will add labels to every repository that this bot is installed on. These do not feel like they belong on every repository.

@chingor13 I agree that these labels will only apply to a small number of repositories. What would be the costs associated with accepting this pull request?

@chingor13
Copy link
Contributor

What would be the costs associated with accepting this pull request?

These labels could annoy repository maintainers that don't use these labels. The maintainers won't be able to remove the labels (they will be readded the next night).

This bot is installed on ~800 googleapis and 25 GoogleCloudPlatform repos and is only needed by a handful of repos.

@rsamborski rsamborski reopened this Sep 13, 2023
@rsamborski rsamborski closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants