feat: use combined DRIFT/api index product list #5038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| constructor(allowedApiShortnames: Set<string>) { | ||
| this.allowedApiShortnames = allowedApiShortnames; | ||
| } | ||
| static async build( |
There was a problem hiding this comment.
Why not add these arguments to the constructor?
There was a problem hiding this comment.
I'm not a huge fan of this class reaching out and doing stuff implicitly given an octokit or GCS connection/bucket.
The class really only cares about the allowed shortnames and the schema. Therefore, I opted to put the API calls into a helper method and pass only the data necessary for the validator into the class.
|
Closing in favor of #5037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation uses the combined product list which is maintained by snippet-bot (from #5014)
Fixes #5036