refactor: use sinon to mock octokit methods #5195

chingor13 · 2023-09-06T22:18:11Z

feat!: require node 18
feat!: remove addOrUpdateIssueComment which is moved to issue-utils.

generated-files-bot · 2023-09-06T22:20:20Z

Warning: This pull request is touching the following templated files:

.github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

packages/gcf-utils/src/configuration.ts

packages/gcf-utils/src/installations.ts

chingor13 added 3 commits September 5, 2023 15:05

test(deps): update nock version

1235309

refactor(test): use sinon to mock octokit methods

402afde

ci: use node 18

4d60132

chingor13 added 4 commits September 6, 2023 15:40

ci: disable coverage

73b151e

re-enable c8 and use in mocha config

8bf793d

conditionally use node 18 for gcf-utils

613bc4e

feat!: drop node 14 and 16 support

18f837f

chingor13 marked this pull request as ready for review September 6, 2023 23:05

chingor13 requested a review from a team as a code owner September 6, 2023 23:05

blunderbuss-gcf bot assigned SurferJeffAtGoogle Sep 6, 2023

SurferJeffAtGoogle suggested changes Sep 7, 2023

View reviewed changes

packages/gcf-utils/src/configuration.ts Show resolved Hide resolved

packages/gcf-utils/src/installations.ts Show resolved Hide resolved

docs: add comments for interfaces

9e755f9

chingor13 requested a review from SurferJeffAtGoogle September 7, 2023 21:13

SurferJeffAtGoogle approved these changes Sep 11, 2023

View reviewed changes

chingor13 merged commit 057125e into main Sep 11, 2023
23 checks passed

chingor13 deleted the refactor-gcf-utils branch September 11, 2023 16:43

Provide feedback