fix: correctly calculate retry attempt #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
commented
Jul 31, 2020
| @@ -272,7 +272,7 @@ describe('retry-request', function () { | |||
| }; | |||
|
|
|||
| retryRequest(URI_404, opts, function (err) { | |||
| assert.strictEqual(numAttempts, 2); | |||
| assert.strictEqual(numAttempts, 1); | |||
There was a problem hiding this comment.
The default number of retries is 2, which means we should make a total of 3 requests for the user who doesn't have any custom settings. In this case, the test says "we've already made 1 retry" by setting "currentRetryAttempt" to 1. That means there's one more retry to go until we reach 2 retries. So, total number of requests = 1.
'currentRetryAttempt` was introduced exclusively for Bigtable: googleapis/nodejs-bigtable#27. I wasn't the author of that code, but I ran this change against the system tests, and they still pass.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 11, 2022
🤖 I have created a release *beep* *boop* --- ## [4.2.0](v4.1.0...v4.2.0) (2022-04-06) ### Features * support enhanced retry settings ([#35](#35)) ([0184676](0184676)) ### Bug Fixes * add new retry options to types ([#36](#36)) ([3f10798](3f10798)) * correctly calculate retry attempt ([#33](#33)) ([4c852e2](4c852e2)) * use extend instead of object.assign ([#37](#37)) ([8c8dcdd](8c8dcdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was confusing "retry attempts" with "request attempts". This sets the record straight.