Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart read retries #27

Merged
merged 11 commits into from
Jan 19, 2018
Merged

Smart read retries #27

merged 11 commits into from
Jan 19, 2018

Conversation

kolodny
Copy link
Contributor

@kolodny kolodny commented Jan 7, 2018 •
edited

Fixes #7

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
    Appropriate docs were updated (if necessary)

@ghost ghost assigned kolodny Jan 7, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2018
@kolodny kolodny changed the title Smart read retries ready Smart read retries Jan 7, 2018
stephenplusplus
stephenplusplus reviewed Jan 7, 2018
View reviewed changes
src/table.js Outdated
]);

stream.on('error', error => {
// TODO - DO NOT MERGE - @stephenplusplus is this unpipe needed?

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus
stephenplusplus reviewed Jan 9, 2018
View reviewed changes
src/table.js Outdated
if (stream._ended) {
return next();

const retryStream = through.obj();

This comment was marked as spam.

Sign in to view

src/table.js Outdated
const requestStream = this.requestStream(grpcOpts, reqOpts);
requestStream.on('request', () => numRequestsMade++);

const stream = pumpify.obj([

This comment was marked as spam.

Sign in to view

src/table.js Outdated
]);

stream.on('error', error => {
// TODO - DO NOT MERGE - @stephenplusplus is this unpipe needed?

This comment was marked as spam.

Sign in to view

src/table.js Outdated
-1
);
};
const greaterThan = (lhs, rhs) => {

This comment was marked as spam.

Sign in to view

src/table.js Outdated
const greaterThan = (lhs, rhs) => {
return lessThan(rhs, lhs);
};
const greaterThanOrEqualTo = (lhs, rhs) => {

This comment was marked as spam.

Sign in to view

src/table.js Outdated
const normalizeRangeValue = rangeSide => {
return is.object(rangeSide) ? rangeSide.value : rangeSide;
};
const startValue = normalizeRangeValue(range.start);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@codecov
Copy link

codecov bot commented Jan 10, 2018 •
edited

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         949   1000   +51     
=====================================
+ Hits          949   1000   +51
Impacted Files Coverage Δ
src/chunktransformer.js 100% <100%> (ø) ⬆️
src/table.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf623c...c679ec2. Read the comment docs.

kolodny
kolodny commented Jan 10, 2018
View reviewed changes
src/table.js Outdated
const RETRY_STATUS_CODES = new Set([4, 10, 14]);
const MUTATE_ROWS_RETRYABLE_STATUS_CODES = new Set([4, 10, 14]);

// TODO - DO NOT MERGE - Figure out exactly what codes need to be here. Some combination of

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@kolodny kolodny requested a review from sduskis January 10, 2018 21:46
@sduskis sduskis mentioned this pull request Jan 11, 2018
Closed
5 tasks
@kolodny
Copy link
Contributor Author

kolodny commented Jan 19, 2018

@stephenplusplus Were there any other concerns or comments you had? If not I think we're good to merge

@ghost ghost assigned stephenplusplus Jan 19, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 19, 2018
@stephenplusplus stephenplusplus merged commit e4c7cc6 into googleapis:master Jan 19, 2018
@stephenplusplus stephenplusplus mentioned this pull request Feb 14, 2018
Merged
@stephenplusplus stephenplusplus mentioned this pull request Jul 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@sduskis sduskis Awaiting requested review from sduskis

Assignees

@stephenplusplus stephenplusplus

@kolodny kolodny

Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kolodny @googlebot @sduskis @stephenplusplus