Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rad): Fix crash when a param doesn't specify a type #200

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Apr 26, 2023

Fixes googleapis/doc-pipeline#423

The issue, apparently, is that when a @param tag is not annotated with a type, the types field is set to nil, which causes a crash here because we're calling map on the result. Generally, we always include a type for a @param tag, even if it's just [Object], but it looks like one slipped through in https://github.com/googleapis/google-cloud-ruby/pull/21002/files (dataset.rb line 990). I'll fix that separately, but for docgen, we can make it robust against that case by calling to_a on the types to map nil to the empty array before calling map on it.

Also updates the release script so failures in build-rad cause a full abort of publish-rad rather than letting it attempt to publish an incomplete tarball.

@dazuma dazuma requested a review from a team as a code owner April 26, 2023 23:22
@dazuma dazuma merged commit e0adb71 into googleapis:main Apr 27, 2023
4 checks passed
@dazuma dazuma deleted the pr/rad-fixes branch April 27, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate-prod: docfx-ruby-google-cloud-datastore-v2.7.0.tar.gz failed
2 participants