fix(rad): Fix crash when a param doesn't specify a type #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/doc-pipeline#423
The issue, apparently, is that when a
@param
tag is not annotated with a type, thetypes
field is set tonil
, which causes a crash here because we're callingmap
on the result. Generally, we always include a type for a@param
tag, even if it's just[Object]
, but it looks like one slipped through in https://github.com/googleapis/google-cloud-ruby/pull/21002/files (dataset.rb line 990). I'll fix that separately, but for docgen, we can make it robust against that case by callingto_a
on thetypes
to mapnil
to the empty array before callingmap
on it.Also updates the release script so failures in build-rad cause a full abort of publish-rad rather than letting it attempt to publish an incomplete tarball.