fix: _insert_record failed for other adapters #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _insert_record method would fail for adapters other than Spanner, as it would call super with two arguments. This is now changed so the method checks whether the current connection uses Spanner or some other adapter, and based on that calls the super method with 1 or 2 arguments. Fixes #292
product-auto-label
bot
added
the
api: spanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _insert_record method would fail for adapters other than Spanner, as it would call super with two arguments. This is now changed so the method checks whether the current connection uses Spanner or some other adapter, and based on that calls the super method with 1 or 2 arguments.
Fixes #292
Also fixes the issue mentioned in #294