Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigdecimal won't be part of standard library from Ruby 3.4.0 #97

Closed
SandeepTuniki opened this issue Apr 1, 2024 · 1 comment · Fixed by #103
Closed

Bigdecimal won't be part of standard library from Ruby 3.4.0 #97

SandeepTuniki opened this issue Apr 1, 2024 · 1 comment · Fixed by #103
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@SandeepTuniki
Copy link
Contributor

Saw this warning log message during a CI run:

/[workspace/google-cloud-spanner/lib/google/cloud/spanner/convert.rb:20]
warning: bigdecimal was loaded from the standard library,
but will no longer be part of the default gems since Ruby 3.4.0.
Add bigdecimal to your Gemfile or gemspec.

Creating this bug to keep track of the warning before it becomes an error in the future.
@SandeepTuniki SandeepTuniki added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. api: spanner Issues related to the Spanner API. labels Apr 1, 2024
@SandeepTuniki
Copy link
Contributor Author

This doesn't need to be addressed right away, but before Ruby 3.4.0 is released.

@SandeepTuniki SandeepTuniki mentioned this issue Apr 1, 2024
Closed
blowmage added a commit to blowmage/ruby-spanner that referenced this issue May 31, 2024
@blowmage
chore: Resolve BigDecimal warning in Spanner
ef413f6 
Add bigdecimal dependency to Spanner gemspec.
Resolves the following warning:

    warning: bigdecimal was loaded from the standard library,
    but will no longer be part of the default gems since Ruby 3.4.0.
    Add bigdecimal to your Gemfile or gemspec.

Reference-to: googleapis#97
@blowmage blowmage mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Resolve BigDecimal warning in Spanner blowmage/ruby-spanner
2 participants
@dazuma @SandeepTuniki