fix: Make HttpJsonTest generation depend on actual transport setting #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
approved these changes
Jun 17, 2022
vchudnov-g
reviewed
Jun 17, 2022
| @@ -137,7 +137,9 @@ class BazelBuildFileView { | |||
| // Default service name as it appears in the proto. | |||
| : service; | |||
| javaTests.add(javaPackage + "." + actualService + "ClientTest"); | |||
| javaTests.add(javaPackage + "." + actualService + "ClientHttpJsonTest"); | |||
| if ("grpc+rest".equals(transport)) { | |||
There was a problem hiding this comment.
What if transport is only "rest"? Shouldn't we include the test then as well?
There was a problem hiding this comment.
If it is only rest, then the test is called just ClientTest. I.e. HttpJsonTests appear only if there is multitransport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.