feat: Add postfix increment to ServiceStubSettings batch desc (#283)

googleapis · Sep 12, 2020 · 333458a · 333458a
1 parent 26a0582
commit 333458a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/com/google/api/generator/gapic/composer/BatchingDescriptorComposer.java b/src/main/java/com/google/api/generator/gapic/composer/BatchingDescriptorComposer.java
@@ -34,6 +34,7 @@
 import com.google.api.generator.engine.ast.ScopeNode;
 import com.google.api.generator.engine.ast.Statement;
 import com.google.api.generator.engine.ast.TypeNode;
+import com.google.api.generator.engine.ast.UnaryOperationExpr;
 import com.google.api.generator.engine.ast.ValueExpr;
 import com.google.api.generator.engine.ast.Variable;
 import com.google.api.generator.engine.ast.VariableExpr;
@@ -333,7 +334,7 @@ private static MethodDefinition createSplitResponseMethod(
           MethodInvocationExpr.builder()
               .setExprReferenceExpr(batchResponseVarExpr)
               .setMethodName(getSubresponseFieldMethodName)
-              .setArguments(batchMessageIndexVarExpr)
+              .setArguments(UnaryOperationExpr.postfixIncrementWithExpr(batchMessageIndexVarExpr))
               .build();
       innerSubresponseForExprs.add(
           MethodInvocationExpr.builder()

diff --git a/src/test/java/com/google/api/generator/gapic/composer/BatchingDescriptorComposerTest.java b/src/test/java/com/google/api/generator/gapic/composer/BatchingDescriptorComposerTest.java
@@ -140,7 +140,7 @@ public void batchingDescriptor_hasSubresponseField() {
             "List<String> subresponseElements = new ArrayList<>();\n",
             "long subresponseCount = responder.getMessageCount();\n",
             "for (int i = 0; i < subresponseCount; i++) {\n",
-            "subresponseElements.add(batchResponse.getMessageIds(batchMessageIndex));\n",
+            "subresponseElements.add(batchResponse.getMessageIds(batchMessageIndex++));\n",
             "}\n",
             "PublishResponse response ="
                 + " PublishResponse.newBuilder().addAllMessageIds(subresponseElements).build();\n",

diff --git a/...st/java/com/google/api/generator/gapic/composer/ServiceStubSettingsClassComposerTest.java b/...st/java/com/google/api/generator/gapic/composer/ServiceStubSettingsClassComposerTest.java
@@ -1820,7 +1820,7 @@ private static List<Service> parseServices(
           + "            long subresponseCount = responder.getMessageCount();\n"
           + "            for (int i = 0; i < subresponseCount; i++) {\n"
           + "             "
-          + " subresponseElements.add(batchResponse.getMessageIds(batchMessageIndex));\n"
+          + " subresponseElements.add(batchResponse.getMessageIds(batchMessageIndex++));\n"
           + "            }\n"
           + "            PublishResponse response =\n"
           + "               "