[ggj][codegen] fix: handle clientStreamingCall in generated tests (#586)

* fix: fix dep ordering in Bazel dedupe rules * fix: use lowerCamelCase for string types in DefaultValueComposer * fix: handle clientStreamingCall in generated tests
googleapis · Dec 4, 2020 · 98bb43d · 98bb43d
1 parent 1cc2b77
commit 98bb43d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/com/google/api/generator/gapic/composer/ServiceClientTestClassComposer.java b/src/main/java/com/google/api/generator/gapic/composer/ServiceClientTestClassComposer.java
@@ -1089,7 +1089,8 @@ private static MethodDefinition createStreamingRpcTestMethod(
                   .setName("requestObserver")
                   .build());
       List<Expr> callableMethodArgs = new ArrayList<>();
-      if (!method.stream().equals(Method.Stream.BIDI)) {
+      if (!method.stream().equals(Method.Stream.BIDI)
+          && !method.stream().equals(Method.Stream.CLIENT)) {
         callableMethodArgs.add(requestVarExpr);
       }
       callableMethodArgs.add(responseObserverVarExpr);
@@ -1361,7 +1362,8 @@ private static List<Statement> createStreamingRpcExceptionTestStatements(
                   .build());
 
       List<Expr> callableMethodArgs = new ArrayList<>();
-      if (!method.stream().equals(Method.Stream.BIDI)) {
+      if (!method.stream().equals(Method.Stream.BIDI)
+          && !method.stream().equals(Method.Stream.CLIENT)) {
         callableMethodArgs.add(requestVarExpr);
       }
       callableMethodArgs.add(responseObserverVarExpr);

diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClientTest.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClientTest.golden
@@ -424,8 +424,7 @@ public class EchoClientTest {
     MockStreamObserver<EchoResponse> responseObserver = new MockStreamObserver<>();
 
     ClientStreamingCallable<EchoRequest, EchoResponse> callable = client.collectCallable();
-    ApiStreamObserver<EchoRequest> requestObserver =
-        callable.clientStreamingCall(request, responseObserver);
+    ApiStreamObserver<EchoRequest> requestObserver = callable.clientStreamingCall(responseObserver);
 
     requestObserver.onNext(request);
     requestObserver.onCompleted();
@@ -449,8 +448,7 @@ public class EchoClientTest {
     MockStreamObserver<EchoResponse> responseObserver = new MockStreamObserver<>();
 
     ClientStreamingCallable<EchoRequest, EchoResponse> callable = client.collectCallable();
-    ApiStreamObserver<EchoRequest> requestObserver =
-        callable.clientStreamingCall(request, responseObserver);
+    ApiStreamObserver<EchoRequest> requestObserver = callable.clientStreamingCall(responseObserver);
 
     requestObserver.onNext(request);