Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement awaitTermination() for HttpJson's Channel #1663

Closed
lqiu96 opened this issue May 1, 2023 · 0 comments · Fixed by #1677
Closed

Implement awaitTermination() for HttpJson's Channel #1663

lqiu96 opened this issue May 1, 2023 · 0 comments · Fixed by #1677
Assignees
@lqiu96
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented May 1, 2023

Inside ManagedHttpJsonChannel's awaitTermination() method,
https://github.com/googleapis/gapic-generator-java/blob/4054bc668daf797a8fce798843e0ec4cda669faa/gax-java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/ManagedHttpJsonChannel.java#L105-L108

there is a TODO that simply returns false. Implement this functionality.
@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 1, 2023
@lqiu96 lqiu96 mentioned this issue May 1, 2023
Merged
@blakeli0 blakeli0 mentioned this issue May 9, 2023
Merged
@lqiu96 lqiu96 self-assigned this May 12, 2023
@lqiu96 lqiu96 mentioned this issue May 12, 2023
Merged
4 tasks
suztomo pushed a commit to suztomo/gapic-generator-java that referenced this issue May 15, 2023
@gcf-owl-bot
chore: [java] remove flatten plugin dependency check (googleapis#1663) (
223b9ee 
googleapis#991)

chore: remove check for flatten plugin

We have had the check for the flatten-maven-plugin in each
Cloud Java client repository. However, the behavior of the plugin
has been stable and its not each repository's responsibility to
assert the plugin's behavior. A new check is going to be added at
the googleapis/java-shared-config repository to assert the
plugin's behavior when we upgrade its version.
Source-Link: https://togithub.com/googleapis/synthtool/commit/9266ddc3b17fc15f34d2fb88ce8c5f1a4bfe64b0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ae72564aa9c368b9ccd96f4af21f87889fd83b9e60635b80844deb5a2ccd08aa
suztomo pushed a commit to suztomo/gapic-generator-java that referenced this issue May 15, 2023
@gcf-owl-bot
chore: [java] remove flatten plugin dependency check (googleapis#1663) (
500af56 
googleapis#883)

chore: remove check for flatten plugin

We have had the check for the flatten-maven-plugin in each
Cloud Java client repository. However, the behavior of the plugin
has been stable and its not each repository's responsibility to
assert the plugin's behavior. A new check is going to be added at
the googleapis/java-shared-config repository to assert the
plugin's behavior when we upgrade its version.
Source-Link: https://togithub.com/googleapis/synthtool/commit/9266ddc3b17fc15f34d2fb88ce8c5f1a4bfe64b0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ae72564aa9c368b9ccd96f4af21f87889fd83b9e60635b80844deb5a2ccd08aa
suztomo pushed a commit to suztomo/gapic-generator-java that referenced this issue May 15, 2023
@gcf-owl-bot
chore: [java] remove flatten plugin dependency check (googleapis#1663) (
e20e57d 
googleapis#468)

chore: remove check for flatten plugin

We have had the check for the flatten-maven-plugin in each
Cloud Java client repository. However, the behavior of the plugin
has been stable and its not each repository's responsibility to
assert the plugin's behavior. A new check is going to be added at
the googleapis/java-shared-config repository to assert the
plugin's behavior when we upgrade its version.
Source-Link: https://togithub.com/googleapis/synthtool/commit/9266ddc3b17fc15f34d2fb88ce8c5f1a4bfe64b0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ae72564aa9c368b9ccd96f4af21f87889fd83b9e60635b80844deb5a2ccd08aa
@burkedavison burkedavison mentioned this issue May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lqiu96 lqiu96

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement awaitTermination() for MangedHttpJsonChannel googleapis/sdk-platform-java
1 participant
@lqiu96