doc: Update DEVELOPMENT.md for local development. #1237

blakeli0 · 2023-01-10T22:06:23Z

No description provided.

conventional-commit-lint-gcf · 2023-01-10T22:06:29Z

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

lqiu96 · 2023-01-11T04:11:19Z

@blakeli0 I was able to resolve the bazel build issue that I was seeing earlier. Turns out that the gapic-generator-pom-parent has <groupId>com.google.cloud</groupId> which wasn't affected by the rm -rf ~/.m2/repositories/com/google/api command we ran. I'll ask @suztomo tomorrow if the groupId is intended/ correct.

Regardless, I'll add a small blurb in like a FAQ/ common errors section about trying the rm -rf ~/.m2/repositories/com/google/cloud/gapic-generator-java-pom-parent/ folder and try again.

DEVELOPMENT.md

Co-authored-by: Tomo Suzuki <suztomo@gmail.com>

DEVELOPMENT.md

Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>

lqiu96 · 2023-01-18T18:09:10Z

@burkedavison @suztomo @alicejli Could you all take another look at the updated DEVELOPMENT.md? Thanks!

DEVELOPMENT.md

Co-authored-by: Tomo Suzuki <suztomo@gmail.com>

suztomo

Trying the "Before" and "After".

DEVELOPMENT.md

suztomo · 2023-01-24T15:58:22Z

DEVELOPMENT.md

+           "com.google.api:gapic-generator-java:" + _gapic_generator_java_version,
+        ],
+        #Update this False for local development
+        fail_on_missing_checksum = False,


(I'm Bazel novice) Can't this True/False be a variable, based on _gapic-generator_java_version has SNAPSHOT?

I think it's doable as Bazel scripts are basically a Python variant, but we may want to test non-SNAPSHOT version locally sometimes.

suztomo

It worked.

DEVELOPMENT.md

burkedavison · 2023-01-24T21:03:51Z

DEVELOPMENT.md

-  bazel test //test/integration:redis
-  ```
+    ```sh
+    bazel test //test/integration:redis


Should all of these bazel commands be using bazelisk instead? (CC @suztomo )

Yes, use bazelisk where applicable.

Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>

gcf-merge-on-green · 2023-02-01T05:06:12Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

sonarcloud · 2023-02-01T14:09:52Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

* fix: Allow custom http bindings for LROs * fix: Update generator and GAX to support custom HTTP Bindings for operations * fix: Use static Map for custom Operation REST Http Bindings * chore: Update golden test cases * chore: Update showcase tests * chore: Update golden ITs * chore: Add back origin HttpJsonOperationStub.create() methods * fix(deps): update dependency com.google.auth:google-auth-library-bom to v1.15.0 (#1278) * doc: Update DEVELOPMENT.md for local development. (#1237) * chore: Create a default mapping in OperationStub * chore: Do not generate custom bindings if there are none * chore: Update golden units * chore: Update all test cases * chore: Fix format issues * fix: remove constant operation binding field * chore: Clean up code * chore: Resolve sonar comments * chore: DEVELOPMENT.md formatting fix (#1289) * ci: use java-shared-dependencies in google-cloud-java repository for downstream test (#1291) * ci: use java-shared-dependencies in google-cloud-java * No need to modify google-cloud-jar-parent * fix(java): initialize netty-shaded at run-time and add reflection configurations for netty classes (#1290) * fix(java): initialize netty-shaded at run-time and add reflection configurations for netty classes * ci(showcase): disable rest_numeric_enum for showcase testing (#1284) * ci(showcase): disable rest_numeric_enum feature in showcase tests * chore(main): release 2.15.0 (#1269) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(main): release 2.15.1-SNAPSHOT (#1292) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: Pin Bazel version to 5.2.0 (#1304) Pin Bazel version to 5.2.0 as googleapis already updated to 5.2.0 * build(deps): bump cryptography from 38.0.3 to 39.0.1 in /.kokoro (#1297) Bumps [cryptography](https://github.com/pyca/cryptography) from 38.0.3 to 39.0.1. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@38.0.3...39.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mridula <66699525+mpeddada1@users.noreply.github.com> * chore: (cleanup) removing unused files (#1265) * chore: (cleanup) removing unused files * chore: working on comments * chore: removing unused Gradle files in api-common-java, gax-java, java-common-protos, and java-iam (#1305) The build is Maven or Bazel. The Gradle files in the recently migrated repositories (api-common-java, gax-java, java-common-protos, and java-iam) are not used. Note that this pull request is not touching rules_java_gapic/resources/gradle which is still used to generate Gradle files for self-service client libraries. * chore: updated gax-java contribution doc (#1334) Removing unnecessary files * fix: use pkg_tar from rules_pkg (#1303) * chore: Fix pre-commit. (#1294) * chore: update CONTRIBUTING.md (#1346) * fix(deps): update dependency io.grpc:grpc-bom to v1.53.0 (#1345) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | `1.52.1` -> `1.53.0` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.53.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.53.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.53.0/compatibility-slim/1.52.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.53.0/confidence-slim/1.52.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.53.0`](https://togithub.com/grpc/grpc-java/releases/tag/v1.53.0) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.52.1...v1.53.0) ##### New Features - googleapis: Allow user set c2p bootstrap config ([#9856](https://togithub.com/grpc/grpc-java/issues/9856)) - xds: Add contain and stringMatcher in `RouteConfiguration` ([#9845](https://togithub.com/grpc/grpc-java/issues/9845)) - core: Add `grpc-previous-rpc-attempts` to the initial response metadata ([#9686](https://togithub.com/grpc/grpc-java/issues/9686)) - servlet: Implement gRPC server as a Servlet ([#8596](https://togithub.com/grpc/grpc-java/issues/8596)) - authz: Implement static authorization server interceptor ([#8934](https://togithub.com/grpc/grpc-java/issues/8934)) ##### Examples - servlet: Add servlet example ([#8596](https://togithub.com/grpc/grpc-java/issues/8596)) ##### Bug Fixes - xds: Update xds error handling logic. Specifically: - When the ads stream is closed only send errors to subscribers that haven't yet gotten results - Timers to detect missing resources don’t start until the adsStream is ready ([#9745](https://togithub.com/grpc/grpc-java/issues/9745)) - Call subscriber onError callback when xds client fails to connect to server ([#9827](https://togithub.com/grpc/grpc-java/issues/9827)) - core: Delay retriable stream master listener close until all sub streams are closed. This fixes the call executor lifecycle and prevents potential `RejectedExecutionException`. ([#9754](https://togithub.com/grpc/grpc-java/issues/9754)) - core: Free unused `MessageProducer` in `RetriableStream` ([#9853](https://togithub.com/grpc/grpc-java/issues/9853)), fixing a Netty buffer memory leak for cancelled RPCs - api: Fail with `NullPointerException` when a Metadata.Marshaller returns null bytes ([#9781](https://togithub.com/grpc/grpc-java/issues/9781)). This would previously cause a `NullPointerException` later during the RPC. Now the return value of the Marshaller is checked immediately, to help find the broken Marshaller ##### Behavior Changes - xds: Disallow duplicate addresses in the RingHashLB. ([#9776](https://togithub.com/grpc/grpc-java/issues/9776)) - xds: EDS weight sums are allowed up to max unsigned int (was max signed int) ([#9765](https://togithub.com/grpc/grpc-java/issues/9765)) - xds: Drop xds v2 support ([#9760](https://togithub.com/grpc/grpc-java/issues/9760)) ##### Dependencies - JUnit upgraded to 4.13.2 - bazel: Dropped support for Bazel 4. We track the two most recent major versions of Bazel, Bazel 5 and 6. Bazel 4 may still work, but we are no longer testing it - bazel: Include Tomcat annotations dependency for `@Generated` as used by autovalue ([#9762](https://togithub.com/grpc/grpc-java/issues/9762)). Necessary for building xds and rls on Java 9+ - bazel: Export deps from Maven Central-specific stand-in targets ([#9780](https://togithub.com/grpc/grpc-java/issues/9780)). Some Maven Central artifacts are a combination of multiple Bazel targets, like grpc-core is composed of //core:inprocess, //core:internal, //core:util, //api. There is a “//core:core_maven” target used by maven_install that uses the other targets. Previously the target used `runtime_deps` to discourage their use by Bazel users, but that could cause compilation failures from lack of hjars. These targets now use `exports` ##### Acknowledgement [@cpovirk](https://togithub.com/cpovirk) [@niloc132](https://togithub.com/niloc132) [@stephenh](https://togithub.com/stephenh) [@olderwei](https://togithub.com/olderwei) [@pandaapo](https://togithub.com/pandaapo) [@panxuefeng](https://togithub.com/panxuefeng) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  * chore(deps): update dependency org.apache.maven.plugins:maven-deploy-plugin to v3.1.0 (#1340) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `3.0.0` -> `3.1.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.1.0/compatibility-slim/3.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.1.0/confidence-slim/3.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  * chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3.0.0-m9 (#1350) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-surefire-plugin](https://maven.apache.org/surefire/) | `3.0.0-M8` -> `3.0.0-M9` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-surefire-plugin/3.0.0-M9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-surefire-plugin/3.0.0-M9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-surefire-plugin/3.0.0-M9/compatibility-slim/3.0.0-M8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-surefire-plugin/3.0.0-M9/confidence-slim/3.0.0-M8)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-java).  * chore: add rules_pkg to renovate bot ignoreDeps (#1349) Following up on https://togithub.com/googleapis/gapic-generator-java/pull/1338, suppressing renovate PRs for the `rules_pkg` dependency since it will need to align with version used in googleapis. * chore: fix renovate bot ignoreDeps (#1353) Fixes #1352, from missed separator in #1349's changes. * fix(batcher): exceptions in unaryCaller bubble up (#1166) Co-authored-by: Blake Li <blakeli@google.com> * fix(deps): update dependency com.google.auth:google-auth-library-bom to v1.16.0 (#1355) * chore(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.5.0 (#1356) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.1` -> `3.5.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/compatibility-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/confidence-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-java).  * chore(main): release 2.15.1 (#1339) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Emily Wang <emmwang@google.com> * chore: refactoring README and DEVELOPMENT.md (#1351) Thank you for opening a Pull Request! For general contributing guidelines, please refer to [contributing guide](https://togithub.com/googleapis/gapic-generator-java/blob/main/CONTRIBUTING.md) - The old file https://togithub.com/googleapis/gapic-generator-java/blob/main/gapic-generator-java/DEVELOPMENT.md was last touched in mid December. I'm replacing the content with the latest at the root. - Removing the root DEVELOPMENT.md in favor of the file above. - Adding index of the modules at the root README.md - Moving showcase testing guide to showcase/README.md. * chore(main): release 2.15.2-SNAPSHOT (#1358) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: renovate to group Protobuf artifacts (#1362) Copying packageGroup configuration from https://togithub.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/java_library/renovate.json This should avoid separate pull requests for Protobuf: https://togithub.com/googleapis/gapic-generator-java/pull/1155 and https://togithub.com/googleapis/gapic-generator-java/pull/1154 * chore: README.md to explain service_config.proto (#1361) * chore: README.md to explain service_config.proto * add link * chore: Telling owlbot to ignore these files & it's a monorepo (#1372) * chore: Telling owlbot to ignore these files & it's a monorepo * fix: Change the default scope of gax from implementation to api in auto-generated gradle files for self-service client libraries. (#1374) * chore: Update variable name * chore: Fix format issues * fix: Use HttpRule as Value for Custom Bindings * fix: Use HttpRule as Value for Custom Bindings * chore: Add comments * chore: Update tests * fix(deps): update dependency com.google.auth:google-auth-library-bom to v1.15.0 (#1278) * doc: Update DEVELOPMENT.md for local development. (#1237) * chore: Add tests * chore: Cleanup files * chore: Format the files * chore: Add NoCredentialsProvider * chore: Fix sonar comments * chore: Add serviceyaml file for parsing for rest showcase tests * chore: Use service yaml file in test * chore: Fix Echo showcase test * chore: Clean up tests * chore: Sort the map entry to get a consistent ordering for the test * chore: Update showcase and integration tests * chore: Resolve sonar comments * chore: Update comments * chore: Remove a few public constructors * chore: test ci * chore: Remove the cache for java 8 * chore: Update from PR feedback * chore: Update comments * chore: Fix sonar issue * chore: Fix comment * chore: Update to have multiple additional_bindings * chore: Update grpcrest golden test to include httprule * chore: HttpJsonOperationsStub's MethodDescriptors are not static * chore: Add unit tests for HttpJson Operations logic * chore: Resolve lint issues * chore: Clean up test code * chore: Resolve pr comments * chore: Add VisibleForTesting annotation --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Blake Li <blakeli@google.com> Co-authored-by: Mike Eltsufin <meltsufin@google.com> Co-authored-by: Tomo Suzuki <suztomo@gmail.com> Co-authored-by: Mridula <66699525+mpeddada1@users.noreply.github.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Deepankar Dixit <90280028+ddixit14@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com> Co-authored-by: Emily Wang <emmwang@google.com> Co-authored-by: Diego Alonso Marquez Palacios <diegomarquezp@google.com>

Update DEVELOPMENT.md for local development.

274b12c

blakeli0 requested a review from a team as a code owner January 10, 2023 22:06

lqiu96 added 2 commits January 11, 2023 11:22

docs: Update section with cleaning local m2

995342c

Merge branch 'main' into update-doc

cfdf136

suztomo reviewed Jan 11, 2023

View reviewed changes

DEVELOPMENT.md Show resolved Hide resolved

suztomo reviewed Jan 11, 2023

View reviewed changes

DEVELOPMENT.md Show resolved Hide resolved

suztomo reviewed Jan 11, 2023

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

lqiu96 and others added 2 commits January 11, 2023 13:14

Update DEVELOPMENT.md

bbf502d

Co-authored-by: Tomo Suzuki <suztomo@gmail.com>

Update DEVELOPMENT.md

1dc5c1a

Co-authored-by: Tomo Suzuki <suztomo@gmail.com>

burkedavison reviewed Jan 11, 2023

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

lqiu96 and others added 9 commits January 11, 2023 13:15

Merge branch 'main' into update-doc

1da0fed

Update DEVELOPMENT.md

9b2bae6

Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>

Merge branch 'main' into update-doc

a8b91e0

docs: Update with a FAQ section

04a9c3f

chore: Update with note about pre-commit hooks

8357c36

Merge branch 'main' into update-doc

274e8ee

chore: Update the main development.md

083e1e5

chore: Update spacing

7edade2

Merge branch 'main' into update-doc

73b6367

suztomo reviewed Jan 18, 2023

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

suztomo reviewed Jan 18, 2023

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

lqiu96 and others added 3 commits January 18, 2023 13:42

Update DEVELOPMENT.md

25561a4

Co-authored-by: Tomo Suzuki <suztomo@gmail.com>

chore: Update docs per comments

663e595

Merge branch 'main' into update-doc

a103bd6

suztomo reviewed Jan 24, 2023

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

suztomo reviewed Jan 24, 2023

View reviewed changes

DEVELOPMENT.md Show resolved Hide resolved

suztomo reviewed Jan 24, 2023

View reviewed changes

suztomo approved these changes Jan 24, 2023

View reviewed changes

diegomarquezp approved these changes Jan 24, 2023

View reviewed changes

burkedavison reviewed Jan 24, 2023

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

burkedavison reviewed Jan 24, 2023

View reviewed changes

DEVELOPMENT.md Show resolved Hide resolved

burkedavison reviewed Jan 24, 2023

View reviewed changes

blakeli0 and others added 4 commits January 31, 2023 11:26

Apply suggestions from code review

1490865

Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>

Merge branch 'main' into update-doc

e7d3e5f

Update DEVELOPMENT.md

5f70202

Update DEVELOPMENT.md

6d6cc52

blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Jan 31, 2023

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2023

Merge branch 'main' into update-doc

6f5b31f

blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2023

blakeli0 merged commit 4b98054 into main Feb 1, 2023

blakeli0 deleted the update-doc branch February 1, 2023 14:33

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2023

lqiu96 pushed a commit that referenced this pull request Feb 1, 2023

doc: Update DEVELOPMENT.md for local development. (#1237)

d8761bc

lqiu96 pushed a commit that referenced this pull request Feb 23, 2023

doc: Update DEVELOPMENT.md for local development. (#1237)

62edb0e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: Update DEVELOPMENT.md for local development. #1237

doc: Update DEVELOPMENT.md for local development. #1237

blakeli0 commented Jan 10, 2023

conventional-commit-lint-gcf bot commented Jan 10, 2023

lqiu96 commented Jan 11, 2023 •

edited

lqiu96 commented Jan 18, 2023 •

edited

suztomo left a comment

suztomo Jan 24, 2023

blakeli0 Jan 31, 2023

suztomo left a comment

burkedavison Jan 24, 2023

suztomo Jan 24, 2023

gcf-merge-on-green bot commented Feb 1, 2023

sonarcloud bot commented Feb 1, 2023

doc: Update DEVELOPMENT.md for local development. #1237

doc: Update DEVELOPMENT.md for local development. #1237

Conversation

blakeli0 commented Jan 10, 2023

conventional-commit-lint-gcf bot commented Jan 10, 2023

lqiu96 commented Jan 11, 2023 • edited

lqiu96 commented Jan 18, 2023 • edited

suztomo left a comment

Choose a reason for hiding this comment

suztomo Jan 24, 2023

Choose a reason for hiding this comment

blakeli0 Jan 31, 2023

Choose a reason for hiding this comment

suztomo left a comment

Choose a reason for hiding this comment

burkedavison Jan 24, 2023

Choose a reason for hiding this comment

suztomo Jan 24, 2023

Choose a reason for hiding this comment

gcf-merge-on-green bot commented Feb 1, 2023

sonarcloud bot commented Feb 1, 2023

lqiu96 commented Jan 11, 2023 •

edited

lqiu96 commented Jan 18, 2023 •

edited