Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update protobuf dependency to match workspace #1670

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented May 9, 2023

Updating dependencies.properties protobuf version to match workspace version. Looks like renovate-bot doesn't update these automatically.

parent-pom is updated to match workspace: https://github.com/googleapis/gapic-generator-java/blob/main/gapic-generator-java-pom-parent/pom.xml#LL33C24-L33C24

@alicejli alicejli requested a review from a team as a code owner May 9, 2023 14:29
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ddixit14
Copy link
Contributor

ddixit14 commented May 9, 2023

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@suztomo suztomo merged commit 32dba64 into main May 9, 2023
@suztomo suztomo deleted the updateDependency branch May 9, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants