chore: remove template_excludes in the generation config
#2801
Conversation
product-auto-label
bot
added
size: m
| @@ -1,19 +1,5 @@ | |||
| gapic_generator_version: 2.40.2-SNAPSHOT | |||
| googleapis_commitish: 3d50414a7ff3f0b8ffe8ad7858257396e4f18131 | |||
| template_excludes: | |||
There was a problem hiding this comment.
What is the behavior now this is removed? From the logic here, it should be fine for existing libraries. If we want to create new libraries with empty template_excludes, are we going to create an owlbot.py with empty template_excludes section?
There was a problem hiding this comment.
If we want to create new libraries with empty template_excludes, are we going to create an owlbot.py with empty template_excludes section?
Yes, the exclusions in owlbot.py is empty.
There was a problem hiding this comment.
How did we populate it before without hermetic build? Maybe we can populate a default list like this?
".github/*",
".kokoro/*",
"samples/*",
"CODE_OF_CONDUCT.md",
"CONTRIBUTING.md",
"LICENSE",
"SECURITY.md",
"java.header",
"license-checks.xml",
"renovate.json",
".gitignore"
There was a problem hiding this comment.
Yes, it's hard coded in the new-client.py
There was a problem hiding this comment.
I think it was hardcode in new-client.py, but since it does not exist anymore, is it still hardcoded somewhere?
There was a problem hiding this comment.
No, the only place that may have template exclusions is generation config.
This parameter is used to generate owlbot.py if it doesn't exist. Since we don't have this situation, we can remove this parameter.
There was a problem hiding this comment.
Can we hardcode it somewhere in our code? So that we don't have to specify it anymore in google-cloud-java?
There was a problem hiding this comment.
I removed template_exclusions from the config.
|
JoeWang1127
changed the title
template_excludes a non-required parametertemplate_excludes in the generation config
|
There was a problem hiding this comment.
I think we still confirm the template excludes behave correctly using the owlbot.py golden test, right?
There was a problem hiding this comment.
Yes, the unit test is not changed.
In this PR:
template_excludesin the generation configREADME.mdFollow up of #2792.