Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[samplecode][Prepare][1/2]Add ResourceName map into ClassComposer prepare for the samplecode implementation #569

Closed
wants to merge 5 commits into from
Closed

[samplecode][Prepare][1/2]Add ResourceName map into ClassComposer prepare for the samplecode implementation #569

wants to merge 5 commits into from

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Nov 25, 2020 •
edited

In order to compose default value in the sample code. We require ResourceName maps pass down to the SampleCodeComposer. See the reference at #573 use case

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2020
@summer-ji-eng summer-ji-eng changed the title Add ResourceName map into ClassComposer interface [samplecode]Add ResourceName map into ClassComposer interface Nov 30, 2020
miraleung
miraleung suggested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still needed, since we're no longer adding the map to the interface?

@summer-ji-eng
Copy link
Contributor Author

Is this PR still needed, since we're no longer adding the map to the interface?

In my opinion, yes. This PR is mainly for add resourceNames map into GapicClass where it is prepare work for the rest implementation.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 1, 2020
miraleung
miraleung suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please change the PR's title? Also, can we include this changes with the PR that needs it, since the motivation for this change will not be clear to future readers?

src/main/java/com/google/api/generator/gapic/composer/ServiceClientClassComposer.java Outdated Show resolved Hide resolved
@summer-ji-eng summer-ji-eng changed the title [samplecode]Add ResourceName map into ClassComposer interface [samplecode]Add ResourceName map into ClassComposer interface prepare for the samplecode implementation Dec 2, 2020
@summer-ji-eng summer-ji-eng changed the title [samplecode]Add ResourceName map into ClassComposer interface prepare for the samplecode implementation [samplecode]Add ResourceName map into ClassComposer prepare for the samplecode implementation Dec 2, 2020
@summer-ji-eng
Copy link
Contributor Author

Could we please change the PR's title? Also, can we include this changes with the PR that needs it, since the motivation for this change will not be clear to future readers?

I changed the PR's title. But feel free to change if you have better naming. Thanks a lot.

@summer-ji-eng summer-ji-eng changed the title [samplecode]Add ResourceName map into ClassComposer prepare for the samplecode implementation [samplecode][Prepare][1/2]Add ResourceName map into ClassComposer prepare for the samplecode implementation Dec 2, 2020
miraleung
miraleung suggested changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we include this changes with the PR that needs it, since the motivation for this change will not be clear to future readers?

Could we merge this into the PR that actually uses the resource name map? Would prefer this since the refactoring is relatively straightforward, and the usage will help provide the appropriate motivation for future readers.

@summer-ji-eng
Copy link
Contributor Author

Also, can we include this changes with the PR that needs it, since the motivation for this change will not be clear to future readers?

Could we merge this into the PR that actually uses the resource name map? Would prefer this since the refactoring is relatively straightforward, and the usage will help provide the appropriate motivation for future readers.

All right. Close this PR, #573 will cover this. Thanks.

@summer-ji-eng summer-ji-eng deleted the add_resource_name_0 branch January 19, 2021 23:18
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
deps: update iam.version to v1.2.1 (#569)
ff03c65
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore(main): release 2.7.0 (#575)
79f64a7 
🤖 I have created a release *beep* *boop*
---


## [2.7.0](googleapis/java-shared-dependencies@v2.6.0...v2.7.0) (2022-01-28)


### Dependencies

* update dependency com.fasterxml.jackson:jackson-bom to v2.13.1 ([#555](googleapis/java-shared-dependencies#555)) ([4ebc46f](googleapis/java-shared-dependencies@4ebc46f))
* update dependency com.google.api-client:google-api-client-bom to v1.33.1 ([#580](googleapis/java-shared-dependencies#580)) ([4e4bd3f](googleapis/java-shared-dependencies@4e4bd3f))
* update dependency com.google.api:api-common to v2.1.3 ([#587](googleapis/java-shared-dependencies#587)) ([cb5fee9](googleapis/java-shared-dependencies@cb5fee9))
* update dependency com.google.auth:google-auth-library-bom to v1.4.0 ([#578](googleapis/java-shared-dependencies#578)) ([e480d45](googleapis/java-shared-dependencies@e480d45))
* update dependency com.google.errorprone:error_prone_annotations to v2.11.0 ([#582](googleapis/java-shared-dependencies#582)) ([716ff2b](googleapis/java-shared-dependencies@716ff2b))
* update dependency com.google.http-client:google-http-client-bom to v1.41.2 ([#579](googleapis/java-shared-dependencies#579)) ([f63d0dc](googleapis/java-shared-dependencies@f63d0dc))
* update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.0 ([#576](googleapis/java-shared-dependencies#576)) ([5eb6134](googleapis/java-shared-dependencies@5eb6134))
* update dependency com.google.protobuf:protobuf-bom to v3.19.3 ([#571](googleapis/java-shared-dependencies#571)) ([5448af9](googleapis/java-shared-dependencies@5448af9))
* update dependency io.grpc:grpc-bom to v1.44.0 ([#586](googleapis/java-shared-dependencies#586)) ([f406a7d](googleapis/java-shared-dependencies@f406a7d))
* update dependency org.checkerframework:checker-qual to v3.21.1 ([#554](googleapis/java-shared-dependencies#554)) ([5418bc5](googleapis/java-shared-dependencies@5418bc5))
* update gax.version to v2.11.0 ([#581](googleapis/java-shared-dependencies#581)) ([5fe5b79](googleapis/java-shared-dependencies@5fe5b79))
* update gax.version to v2.9.0 ([#573](googleapis/java-shared-dependencies#573)) ([864f6b3](googleapis/java-shared-dependencies@864f6b3))
* update google.common-protos.version to v2.7.2 ([#588](googleapis/java-shared-dependencies#588)) ([b7204ef](googleapis/java-shared-dependencies@b7204ef))
* update google.core.version to v2.4.0 ([#589](googleapis/java-shared-dependencies#589)) ([f4300ef](googleapis/java-shared-dependencies@f4300ef))
* update iam.version to v1.2.1 ([#569](googleapis/java-shared-dependencies#569)) ([ff03c65](googleapis/java-shared-dependencies@ff03c65))
* update opencensus.version to v0.30.0 ([#552](googleapis/java-shared-dependencies#552)) ([37407e2](googleapis/java-shared-dependencies@37407e2))
* update opencensus.version to v0.31.0 ([#585](googleapis/java-shared-dependencies#585)) ([690cf8d](googleapis/java-shared-dependencies@690cf8d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
deps: update dependency io.grpc:grpc-bom to v1.41.0 (#569)
b58c0b1 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | `1.40.1` -> `1.41.0` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.41.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.41.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.41.0/compatibility-slim/1.40.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.41.0/confidence-slim/1.40.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>grpc/grpc-java</summary>

### [`v1.41.0`](https://togithub.com/grpc/grpc-java/releases/v1.41.0)

[Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.40.1...v1.41.0)

##### API Changes

-   stub: Mark Stub-based MetadataUtils methods deprecated ([#&#8203;8395](https://togithub.com/grpc/grpc-java/issues/8395)). The interceptor-based versions have been stable for a long time and are preferred

##### Bug Fixes

-   census: Fixed a data race in CensusStatsModule which in rare cases may cause NullPointerException ([#&#8203;8459](https://togithub.com/grpc/grpc-java/issues/8459))
-   xds: Fixed a bug in SharedCallCounterMap which in rare cases may cause NullPointerException ([#&#8203;8397](https://togithub.com/grpc/grpc-java/issues/8397))
-   core: `ServerCall.isCancelled()` and `ServerCallStreamObserver.isCancelled()` implementations no longer incorrectly return true at the end of every RPC ([#&#8203;8408](https://togithub.com/grpc/grpc-java/issues/8408))
-   core: ManagedChannel no longer immediately exits idle mode after an `enterIdle()` call when it has any calls in progress
-   netty-shaded: Modify the shading operation to transform native-image resources so they correctly reference shaded class names ([#&#8203;7540](https://togithub.com/grpc/grpc-java/issues/7540))
-   netty-shaded: Rename native-image resources to avoid collisions with Netty’s copy, which were modified starting in 1.39.0
-   rls: avoid NullPointerException in RLS in certain circumstances when calling `channel.getState(true)` or if a parent load balancer requests a connection ([#&#8203;8379](https://togithub.com/grpc/grpc-java/issues/8379))

##### New Features

-   xds: xDS-based TLS security (gRFC 29) is now stable
-   util: Added new classes AdvancedTlsX509TrustManager and AdvancedTlsX509KeyManager, which support reloading keys and trust roots as they change. They also can make custom verification easier by handling the hostname verification. ([#&#8203;8175](https://togithub.com/grpc/grpc-java/issues/8175))
-   xds: Added `XdsNameResolverProvider.createForTest()` to allow using a different bootstrap configuration in tests ([#&#8203;8358](https://togithub.com/grpc/grpc-java/issues/8358))

##### Behavior Changes

-   rls: migrated the deprecated server and path fields in RouteLookupRequest to using the new extra_keys field in RLS config

##### Improvements

-   api: Document that NameResolvers shouldn’t block within their methods ([#&#8203;8398](https://togithub.com/grpc/grpc-java/issues/8398)). The offload executor should be used for blocking operations
-   stub: Document StreamObserver is an async API, and how it internally may buffer ([#&#8203;8449](https://togithub.com/grpc/grpc-java/issues/8449))

##### Dependencies

-   Upgraded error_prone_annotations to 2.9.0
-   cronet: Cronet upgraded to version 92.4515.131

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore: release 2.1.7 (#571)
a9a2063 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.1.7](https://www.github.com/googleapis/java-core/compare/v2.1.6...v2.1.7) (2021-09-23)


### Dependencies

* update dependency io.grpc:grpc-bom to v1.41.0 ([#569](https://www.github.com/googleapis/java-core/issues/569)) ([b58c0b1](https://www.github.com/googleapis/java-core/commit/b58c0b1ba2d5a5ef273564df90b71fce49982a1b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraleung miraleung miraleung requested changes

@xiaozhenliu-gg5 xiaozhenliu-gg5 Awaiting requested review from xiaozhenliu-gg5

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@summer-ji-eng @miraleung