feat: Drop support for Ruby 2.4 and add support for Ruby 3.0 #178
Conversation
google-cla
bot
added
the
cla: yes
dazuma
changed the title
.rubocop.yml
Outdated
| - "lib/signet/oauth_1/client.rb" | ||
| - "lib/signet/oauth_1/credential.rb" | ||
| - "lib/signet/oauth_1/server.rb" | ||
| - "lib/signet/oauth_2/client.rb" |
There was a problem hiding this comment.
With so many of the significant files excluded, what do you think about just disabling these cops instead, or maybe setting them to the upper limits that allow all files to pass?
There was a problem hiding this comment.
Yeah good point. I started by trying just to exclude a minimal set of files, but now that's pretty much all of them. I'll look at upping the limits for now.
There was a problem hiding this comment.
That's what I prefer. As a rule, I'd rather up the limits for all files than set special excludes (or even worse, inline disables). It's more democratic: If one file deserves extra AbcSize, we all deserve extra AbcSize!
| # rubocop:disable Metrics/AbcSize | ||
| # rubocop:disable Metrics/CyclomaticComplexity | ||
| # rubocop:disable Metrics/MethodLength | ||
| # rubocop:disable Metrics/PerceivedComplexity | ||
|
|
There was a problem hiding this comment.
Thanks for moving out all these disable comments! ❤️
required_ruby_versionto>= 2.5google-styleto~> 1.25.1