Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

use csv-string package to format --csv output #69

Merged
merged 11 commits into from Nov 1, 2018
Merged

use csv-string package to format --csv output #69

merged 11 commits into from Nov 1, 2018

Conversation

danoscarmike
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@danoscarmike
Copy link
Contributor Author

@JustinBeckwith can you PTAQL?

@JustinBeckwith
Copy link
Contributor

Thanks! Out of curiosity - why? Is there a problem this is a solvin'?

@danoscarmike
Copy link
Contributor Author

Properly handling the issue title strings by quoting any string that itself includes commas, quotes etc.

@danoscarmike
Copy link
Contributor Author

Prompting me to think about this - for my use case I could probably safely abstract away the issue title. And I think the other fields are csv safe with just the .join(','). All that said I don't think this change hurts :)

@JustinBeckwith JustinBeckwith merged commit 86e9ef3 into googleapis:master Nov 1, 2018
@danoscarmike danoscarmike mentioned this pull request Nov 13, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danoscarmike @JustinBeckwith @googlebot