Skip to content

Commit

Permalink
samples: pull in latest typeless bot, clean up some comments (#1698)
Browse files Browse the repository at this point in the history
samples: pull in latest typeless bot, clean up some comments
  • Loading branch information
feywind committed Nov 4, 2022
1 parent 520c18d commit 0a68e56
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docker/owlbot/nodejs/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ RUN find /synthtool -type d -exec chmod a+x {} \;
# * gts/typescript are used for linting.
# * google-gax is used for compiling protos.
RUN cd /synthtool && mkdir node_modules && npm i gts@3.1.0 google-gax@3.5.2 \
typescript@4.7.4 @google-cloud/typeless-sample-bot@1.0.2
typescript@4.7.4 @google-cloud/typeless-sample-bot@1.0.3

ENTRYPOINT [ "/bin/bash" ]
CMD [ "/synthtool/docker/owlbot/nodejs/entrypoint.sh" ]
2 changes: 1 addition & 1 deletion docker/owlbot/nodejs_mono_repo/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ RUN find /synthtool -type d -exec chmod a+x {} \;
# * gts/typescript are used for linting.
# * google-gax is used for compiling protos.
RUN cd /synthtool && mkdir node_modules && npm i gts@3.1.0 google-gax@3.5.2 \
typescript@4.7.4 @google-cloud/typeless-sample-bot@1.0.2
typescript@4.7.4 @google-cloud/typeless-sample-bot@1.0.3

ENTRYPOINT [ "/bin/bash" ]
CMD [ "/synthtool/docker/owlbot/nodejs_mono_repo/entrypoint.sh" ]
5 changes: 3 additions & 2 deletions synthtool/languages/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,15 @@ def install(hide_output=False):
shell.run(["npm", "install"], hide_output=hide_output)


# This is currently an optional, opt-in part of an individual repo's
# OwlBot.py, and must be called from there before calling owlbot_main.
def typeless_samples_hermetic(hide_output=False):
"""
Converts TypeScript samples in the current Node.js library
to JavaScript samples. Run this step before fix() and friends.
Assumes that typeless-sample-bot is already installed in a well
known location on disk (node_modules/.bin).
This is currently an optional, opt-in part of an individual repo's
OwlBot.py, and must be called from there before calling owlbot_main.
"""
logger.debug("Run typeless sample bot")
shell.run(
Expand Down
5 changes: 3 additions & 2 deletions synthtool/languages/node_mono_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,15 @@ def install(hide_output=False):
shell.run(["npm", "install"], hide_output=hide_output)


# This is currently an optional, opt-in part of an individual repo's
# OwlBot.py, and must be called from there before calling owlbot_main.
def typeless_samples_hermetic(hide_output=False):
"""
Converts TypeScript samples in the current Node.js library
to JavaScript samples. Run this step before fix() and friends.
Assumes that typeless-sample-bot is already installed in a well
known location on disk (node_modules/.bin).
This is currently an optional, opt-in part of an individual repo's
OwlBot.py, and must be called from there before calling owlbot_main.
"""
logger.debug("Run typeless sample bot")
shell.run(
Expand Down

0 comments on commit 0a68e56

Please sign in to comment.