Skip to content

Commit

Permalink
ci: update template so GAPIC_AUTO repos do not require special approv…
Browse files Browse the repository at this point in the history
…ers for Java code (#1494)
  • Loading branch information
suztomo committed Jul 18, 2022
1 parent a4a3599 commit da89e53
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions synthtool/gcp/templates/java_library/.github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
{% if 'codeowner_team' in metadata['repo'] %}
# The {{ metadata['repo']['codeowner_team'] }} is the default owner for changes in this repo
* @googleapis/yoshi-java {{ metadata['repo']['codeowner_team'] }}
{% if 'library_type' in metadata['repo'] and metadata['repo']['library_type'] != 'GAPIC_AUTO' %}
# for handwritten libraries, keep codeowner_team in .repo-metadata.json as owner
**/*.java {{ metadata['repo']['codeowner_team'] }}
{% endif %}
{% else %}
* @googleapis/yoshi-java
{% endif %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,6 @@ permissionRules:
permission: admin
- team: yoshi-java
permission: push
- team: java-samples-reviewers
permission: push

0 comments on commit da89e53

Please sign in to comment.