Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nodejs_mono_repo): update broken links in README #1577

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Sep 13, 2022

Makes sure file names do not contain /workspace/google-cloud-node/, since the post-processor runs from the root, but the link only needs the relative directory.

Since this is a shared function, we need to make the changes in the node post-processing.

@sofisl sofisl requested a review from a team September 13, 2022 00:10
@snippet-bot
Copy link

snippet-bot bot commented Sep 13, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sofisl sofisl changed the title chore(nodejs_mono_repo): update broken links in README fix(nodejs_mono_repo): update broken links in README Sep 13, 2022
@chingor13 chingor13 changed the title fix(nodejs_mono_repo): update broken links in README docs(nodejs_mono_repo): update broken links in README Sep 13, 2022
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 50db768 into master Sep 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the fixBrokenLinksREADMENodejs branch September 13, 2022 15:32
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants