Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [owlbot-java] samples do not need deploy plugin and deps upgrade #1583

Merged
merged 8 commits into from
Sep 26, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Sep 15, 2022

The plugins were added somehow in #430. Removing them from sample's pom.xml to reduce unnecessary RenovateBot pull requests such as googleapis/java-apikeys#4.

Also updating java-shared-dependencies BOM version.

@suztomo suztomo requested a review from a team as a code owner September 15, 2022 14:53
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 15, 2022
@suztomo suztomo changed the title docs: samples do not need deploy plugin docs: samples do not need deploy plugin and deps upgrade Sep 23, 2022
@suztomo suztomo changed the title docs: samples do not need deploy plugin and deps upgrade docs [owlbot-java]: samples do not need deploy plugin and deps upgrade Sep 23, 2022
@suztomo suztomo changed the title docs [owlbot-java]: samples do not need deploy plugin and deps upgrade docs: [owlbot-java] samples do not need deploy plugin and deps upgrade Sep 23, 2022
@suztomo suztomo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 23, 2022
@suztomo
Copy link
Member Author

suztomo commented Sep 23, 2022

Fixing test "owlbot-java-presubmit (repo-automation-bots)"

@suztomo
Copy link
Member Author

suztomo commented Sep 26, 2022

owlbot-java-presubmit (repo-automation-bots) Successful.

@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 26, 2022
@suztomo suztomo merged commit b61387e into master Sep 26, 2022
@suztomo suztomo deleted the suztomo-patch-1 branch September 26, 2022 16:02
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants