Move: excludes arg paths should be relative to source, not destination #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwlui
added
the
type: bug
|
This is needed for https://github.com/googleapis/nodejs-firestore/blob/master/synth.py firestore moved their source location to under dev/ |
crwilcox
approved these changes
Aug 30, 2018
igorbernstein2
added a commit
to igorbernstein2/synthtool
that referenced
this pull request
Apr 25, 2019
googleapis#48 introduced a bug where the exclude path (which is relative to a tracked path) is compared to a source path (which is relative to the source root). This issue was unnoticed because it works ok when the source path has a single component like in firestore: https://github.com/googleapis/nodejs-firestore/blob/89afae/synth.py#L19 But breaks when the source path has multiple components like in bigtable: https://github.com/googleapis/google-cloud-java/blob/264643/google-cloud-clients/google-cloud-bigtable/synth.py#L30 And when the cwd doesn't match the tracked path
Merged
busunkim96
pushed a commit
that referenced
this pull request
Apr 29, 2019
* Fix move excludes #48 introduced a bug where the exclude path (which is relative to a tracked path) is compared to a source path (which is relative to the source root). This issue was unnoticed because it works ok when the source path has a single component like in firestore: https://github.com/googleapis/nodejs-firestore/blob/89afae/synth.py#L19 But breaks when the source path has multiple components like in bigtable: https://github.com/googleapis/google-cloud-java/blob/264643/google-cloud-clients/google-cloud-bigtable/synth.py#L30 And when the cwd doesn't match the tracked path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So if there exists a
source/garbage.md, it will be ignored.Please let me know if this change makes sense to you.