Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move system and samples test from Node 10 to Node 12 #725

Merged
merged 3 commits into from
Aug 21, 2020
Merged

fix: move system and samples test from Node 10 to Node 12 #725

merged 3 commits into from
Aug 21, 2020

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Aug 14, 2020 •
edited
Loading

Want to wait for @SurferJeffAtGoogle to confirm that we can delete these files.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2020
@sofisl sofisl added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 14, 2020
@sofisl sofisl requested a review from bcoe August 14, 2020 20:22
@sofisl sofisl marked this pull request as ready for review August 21, 2020 01:16
@sofisl sofisl merged commit 05de3e1 into master Aug 21, 2020
@chingor13 chingor13 deleted the deleteNode10Tests branch November 19, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sofisl @bcoe