fix(python_library): fix unit test dependency installation #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
Oct 26, 2020
busunkim96
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perviously, system tests allow users to pass in separate lists for
system_test_external_dependenciesandunit_test_local_dependencies, which would install dependencies needed for the test. Unit tests only had a single option calledunit_test_dependencies, which only supported local packages.This PR makes unit tests consistent with system tests by handling
unit_test_external_dependenciesandunit_test_local_dependencies. I keptunit_test_dependenciesaround with it's previous behaviour for backwards compatibility, in case any repos are using it as-is.