This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a first attempt to bring the ace-element to the Polymer 1.0 world.
Some things to notice:
<property>changed
handler since somehow Polymer calls them very early (I think earlier than the dummy editor we setup to avoid just this). Let me know if I am missing something.demo.html
todemo/index.html
index.html
to use<iron-component-page>
templateContent()
in Polymer 1.0 so I inject the theme styles directly to the element. Let me know if I should do this differently.onMutation
in Polymer 1.0 so I setup a MutationObserver to do the work.Looking forward to your feedback.