Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

first attempt to port to Polymer 1.0 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

triglian
Copy link
Contributor

Hi, this is a first attempt to bring the ace-element to the Polymer 1.0 world.

Some things to notice:

  • Prefixed all private methods with _ to match the Polymer style guide.
  • Added basic documentation.
  • I have to check if the editor exists at every <property>changed handler since somehow Polymer calls them very early (I think earlier than the dummy editor we setup to avoid just this). Let me know if I am missing something.
  • Moved demo.html to demo/index.html
  • Adapted index.html to use <iron-component-page>
  • I wasn't able to find an equivalent for templateContent() in Polymer 1.0 so I inject the theme styles directly to the element. Let me know if I should do this differently.
  • There is no onMutation in Polymer 1.0 so I setup a MutationObserver to do the work.

Looking forward to your feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant