Skip to content
This repository has been archived by the owner on Apr 24, 2021. It is now read-only.

Get launching right for Chrome extensions #1935

Open
ussuri opened this issue May 15, 2014 · 5 comments
Open

Get launching right for Chrome extensions #1935

ussuri opened this issue May 15, 2014 · 5 comments
Assignees
Milestone

Comments

@ussuri
Copy link
Contributor

ussuri commented May 15, 2014

Launching via the 'Run' button doesn't work for Chrome extensions: we need to fix that. Once done, the Chrome extension sample should be moved out from under the showWipProjectTemplates dev flag in spark_polymer_ui.html.

@ussuri
Copy link
Contributor Author

ussuri commented May 16, 2014

Currently, the following message appears:

screen shot 2014-05-15 at 5 43 05 pm

We could:

  • Analyze manifest.json
  • Determine app-vs-extension based on the presence of "app" key
  • Install in Chrome
  • If an app, launch
  • If an extension, open tab in Chrome at chrome://extensions/?id=<extension ID>

@ussuri
Copy link
Contributor Author

ussuri commented May 16, 2014

To avoid surprises, copying from #1704:

The "Chrome extension" project type has been moved under a dev flag "wip-project-templates". To enable the flag in the downloaded version of the app, add a file named .spark.json to your top-level project directory, with the following contents:

{
  "wip-project-templates": true
}

Then restart Spark.

Note that Spark needs to know that the above-mentioned directory is your top-level project location. For that to happen, if you just downloaded the app, you will have to create at least one project (a blank one will do). In the process of project creation, Spark will ask you to choose the top-level project location.

@dinhvh
Copy link
Contributor

dinhvh commented Jun 18, 2014

Fixed.

@dinhvh dinhvh closed this as completed Jun 18, 2014
@ussuri ussuri self-assigned this Jun 18, 2014
@ussuri ussuri added this to the MVP1.0: Chrome App dev (Dev preview) milestone Jun 18, 2014
@ussuri
Copy link
Contributor Author

ussuri commented Jun 18, 2014

It's been just hidden under a flag, not fixed.

@ussuri ussuri reopened this Jun 18, 2014
@srsaroop srsaroop modified the milestones: Later, MVP1.0: Chrome App dev (Dev preview) Jul 1, 2014
@DanielHerr
Copy link

The run button should open chrome-extension://id/popup.html, or whatever the browser or page action popup from the manifest is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants