Devoncarew fix startup

[devoncarew]

Fix an exception during startup. We were returning null from a method that callers expected to have return bools.

@ussuri, @dinhviethoa

Uncaught Error: type 'Null' is not a subtype of type 'bool' of 'boolean expression'.
Stack Trace:
#0 dirtyCheckObservables (package:observe/src/dirty_check.dart:61:36)
#1 Observable.dirtyCheck (package:observe/src/observable.dart:35:52)
#2 SparkPolymerUI.refreshFromModel (chrome-extension://kcjgcakhgelcejampmijgkjkadfcncjl/spark_polymer_ui.dart:71:26)
#3 SparkPolymerUI.modelReady (chrome-extension://kcjgcakhgelcejampmijgkjkadfcncjl/spark_polymer_ui.dart:60:21)

[dinhvh]

Lgtm.

Hoa V. Dinh

On Friday, June 6, 2014 at 9:53 PM, Devon Carew wrote:

Fix an exception during startup. We were returning null from a method that callers expected to have return bools.
@ussuri (https://github.com/ussuri), @dinhviethoa (https://github.com/dinhviethoa)
Uncaught Error: type 'Null' is not a subtype of type 'bool' of 'boolean expression'.
Stack Trace:
#0 dirtyCheckObservables (package:observe/src/dirty_check.dart:61:36)
#1 (#1) Observable.dirtyCheck (package:observe/src/observable.dart:35:52)
#2 (#2) SparkPolymerUI.refreshFromModel (chrome-extension://kcjgcakhgelcejampmijgkjkadfcncjl/spark_polymer_ui.dart:71:26)
#3 (#3) SparkPolymerUI.modelReady (chrome-extension://kcjgcakhgelcejampmijgkjkadfcncjl/spark_polymer_ui.dart:60:21)
You can merge this Pull Request by running
git pull https://github.com/devoncarew/spark devoncarew_fix_startup
Or view, comment on, or merge it at:
#2367
Commit Summary
fix an issue with spark not starting up
fix an issue with spark not starting up

File Changes
M ide/app/lib/git/object.dart (https://github.com/dart-lang/spark/pull/2367/files#diff-0) (2)
M widgets/lib/spark_dialog/spark_dialog.dart (https://github.com/dart-lang/spark/pull/2367/files#diff-1) (2)
M widgets/lib/spark_dialog_button/spark_dialog_button.dart (https://github.com/dart-lang/spark/pull/2367/files#diff-2) (8)

Patch Links:
https://github.com/dart-lang/spark/pull/2367.patch
https://github.com/dart-lang/spark/pull/2367.diff

—
Reply to this email directly or view it on GitHub (#2367).