This repository has been archived by the owner on Apr 24, 2021. It is now read-only.
Build improvement #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dinhvh
commented
Oct 12, 2013
dinhvh
commented
- Added "release" task to create a build for CWS.
- Fixed "archive" task to use content of build/polymer-build.
- Workaround https://code.google.com/p/dart/issues/detail?id=14045: Use .dart.precompiled.js instead of .dart.js
added 3 commits
October 11, 2013 21:04
…to use content of build/polymer-build.
… .dart.precompiled.js instead of .dart.js.
| Future<String> increaseBuildNumber(GrinderContext context) { | ||
| // Tweaking build version in manifest. | ||
| File file = new File('app/manifest.json'); | ||
| Future<String> finishedReading = file.readAsString(); |
There was a problem hiding this comment.
If you like, you can also do readAsStringSync() - you wouldn't have to do any async in this method.
|
lgtm! Can you add some docs - either in this file or on a wiki page - outlining the build process? Nothing too long, just a quick overview of the steps. Something like: we copy this here, run this polymer build step, compile this file, and copy everything for packaging. I think we have enough steps now that it'd be good to document. |
Closed
This was referenced Oct 28, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.