Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Added async, await and yield C# keywords support #463

Closed
wants to merge 1 commit into from
Closed

Added async, await and yield C# keywords support #463

wants to merge 1 commit into from

Conversation

pedrolamas
Copy link
Contributor

I added these originally in eace8e0, but it got removed with 7c60184, so I'm adding them back now!

I added these originally in eace8e0, but it got removed with 7c60184, so I'm adding them back now!
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@pedrolamas
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@amroamroamro
Copy link
Contributor

amroamroamro commented Dec 11, 2016

@pedrolamas
FYI, src/prettify.js is auto-generated from the sources in js-modules/*.js,
so your changes will be undone when the makefile is rerun.

I suggest you make modifications to files in js-modules/ in the future.

@pedrolamas
Copy link
Contributor Author

I did these changes on js-modules/prettify.js, isn't that where they are supposed to go in?

@amroamroamro
Copy link
Contributor

amroamroamro commented Dec 11, 2016

It is, I was talking about your old commit :)

@pedrolamas
Copy link
Contributor Author

Ah, thanks! Indeed I can say I learned my lesson!! 😄

@amroamroamro
Copy link
Contributor

I fixed those mishaps in this last update #467
(there was your PR #418 and also PR #384 which were mistakenly undone).
This is now safe to close, thank you.

@pedrolamas pedrolamas deleted the patch-1 branch January 19, 2017 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants