This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Force core-toolbar/core-header to be transparent #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because core-toolbar now has a default background (aa8b336327958382adcae3dcfc43a9cf27292ebc) it breaks `core-scroll-header-panel` because the background color was previously transparent (Polymer/polymer#576). This change forces the content inside of `#headerContent` (either `core-toolbar` or `.core-header`) to be transparent.
|
This will not work for the case that I just want to set background-color on core-toolbar, e.g. |
|
For now, maybe just fix the demo so core-toolbar has background-color transparent (https://github.com/Polymer/core-scroll-header-panel/blob/master/demo.html#L56)? |
|
Hm that's kind of a bummer. I wish there was a way to automatically set the toolbar to transparent if an image background is used |
|
Yeah that's a bummer |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
core-toolbarnow has a default background (aa8b336327958382adcae3dcfc43a9cf27292ebc) it breakscore-scroll-header-panelsince the background color was previously transparent (Polymer/polymer#576). This change forces the content inside of#headerContent(eithercore-toolbaror.core-header) to be transparent again.Fixes Polymer/polymer#576