-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
Deprecated name() in favor of key() for Firebase 2.0.0.
Changes in priority now raise a child_changed event in addition to a child_moved event. For Firebase 2.0.0
Also added demo content limitToFirst and limitToLast
Add to firebase.html demo demonstrate how these should work. Not all are working correctly yet.
@nevir @kevinpschaaf who owns this element and can take a look? @chuckh da man! |
👍 |
@chuckh can you update to be mergeable from master and @nevir @ebidel @kevinpschaaf can somebody get this thing merged? Very needed. 👾 |
Merged this in 45df802. Note, while resolving the conflict with master I messed up the merge such that you didn't get credit for it in the commit history, sorry :(. FYI, I didn't take the change to demo.html; it was a little verbose and non-DRY for our taste, and I wasn't sure about the big chunk of code that was calling into the Firebase API directly, but in the interest of time wanted to get the main changes merged to unblock the other users. Feel free to open another PR with the demo update alone and we can discuss it there. Thanks again for the contribution, this is great! |
👏 thanks! @chuckh you rock. |
@kevinpschaaf glad you where able to merge the changes into the master. I understand why you did not include the demo additions. I do think the demo does need more examples. I found that there are a few nuances with using the firebase-element and the advance query abilities for Firebase 2.0.x:
I was trying to demonstrates those nuances. I will work on another pull request to add more demos being dryer. Let me know if you have any suggestions on how to handle this better. Maybe a demo example of using core-list with firebase-element using OrderByChild and EqualTo. |
This pull request does the following:
This resolves #18.
I have signed the Google Contributor License Agreement