-
Notifications
You must be signed in to change notification settings - Fork 167
Updated project to better support Android Studio #6
Conversation
ankurkotwal
commented
Apr 18, 2016
- Migrated to Android Studio project structure
- Updated Google Play Services dependency to google-play-services-maps:8.4.0
- Removed reference to support library
- Removed references to Eclipse from README
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
4. You should see two projects - "hellomap" and "google-play-services_lib". | ||
5. Ensure both are selected | ||
6. Press "Finish" | ||
4. Press "Ok" | ||
|
||
## Add your API key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section doesn't look right for Android Studio. in the default 'Android' view, the manifest is under 'Application -> manifests'
|
||
## Add your API key | ||
1. Navigate to AndroidManifest.xml, under the "hellomap" project. | ||
1. Navigate to the AndroidManifest.xml file | ||
2. Click the "AndroidManifest.xml" tab, next to "Instrumentation", to see the XML view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line still true?
(originally I meant this in terms of the "instrumentation" tab, but it looks like you've added a custom XML file with the key, so I think this whole block needs an update)
@markmcd @jfschmakeit Have addressed all code review comments. PTAL. |