This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I didn't take care of:
|| thing === undefined
, not a fan of thatfor...in
bodies inhasOwnProperty
checks; there were a lot of them but I assume prototype chain should be respected in all__proto__
is deprecated; seems to be used properlyprop
,object
,obs
,observer
,target
,callback
,skipChanges
,changeRecords
(x2),array
; besidesprop
they're all argument names.prop
is used in theobjectIsEmpty
function and can't be removed