This repository has been archived by the owner on Nov 5, 2022. It is now read-only.
migrate to null safety #50
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## 1.10.0-dev | ||
|
||
- Migrate to null safety. | ||
|
||
## 1.9.0 | ||
|
||
- Enforce 17 new lint rules: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import 'package:pedantic/pedantic.dart'; | ||
|
||
void main() async { | ||
// Normally, calling a function that returns a Future from an async method | ||
// would require you to ignore the unawaited_futures lint with this analyzer | ||
// syntax: | ||
// | ||
// ignore: unawaited_futures | ||
doSomethingAsync(); | ||
|
||
// Wrapping it in a call to `unawaited` avoids that, since it doesn't | ||
// return a Future. This is more explicit, and harder to get wrong. | ||
unawaited(doSomethingAsync()); | ||
} | ||
|
||
Future<void> doSomethingAsync() async {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
name: pedantic | ||
version: 1.9.0 | ||
version: 1.10.0-dev | ||
description: >- | ||
The Dart analyzer settings and best practices used internally at Google. | ||
homepage: https://github.com/dart-lang/pedantic | ||
|
||
environment: | ||
sdk: '>=2.1.1-dev.0.0 <3.0.0' | ||
sdk: '>=2.8.0-dev <3.0.0' | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to
<2.8.0
so that only 2.8.-dev sdks can select this release, per other comments.