This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Resolve work and dest dirs relative to CWD instead of the root. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be really nice to see this merged ... currently the dest_dir is resolved twice against the root, which really produces funny paths and makes it hard to integrate this tool into a build. |
|
Any comments on why this change, or what it fixes? |
|
|
| @@ -23,7 +23,7 @@ var WebComponentShards = function WebComponentShards(options){ | |||
| this.bowerdir = options.bowerdir; | |||
| this.shared_import = options.shared_import; | |||
| this.sharing_threshold = options.sharing_threshold; | |||
| this.dest_dir = url.resolve(this.root, options.dest_dir); | |||
| this.dest_dir = path.resolve(options.dest_dir) + "/"; | |||
There was a problem hiding this comment.
use path.join rather than string concatenation?
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.